Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove seemingly superfluous import of pysam #194

Merged
merged 2 commits into from Jul 22, 2022
Merged

fix: remove seemingly superfluous import of pysam #194

merged 2 commits into from Jul 22, 2022

Conversation

johanneskoester
Copy link
Contributor

No description provided.

@mdshw5 mdshw5 self-assigned this Jul 22, 2022
@mdshw5
Copy link
Owner

mdshw5 commented Jul 22, 2022

Yes, it looks like I was debating between using pysam.VariantFile and vcf.Reader back then. At some point pyvcf became unmaintained, and so new I use PyVCF3. If there is a need, I'm open to a different solution but for now thanks @johanneskoester for removing this unused import.

@mdshw5
Copy link
Owner

mdshw5 commented Jul 22, 2022

It looks like CI is failing due to changes in setuptools_scm that now require python3.7+, so I'll go ahead and merge. Thanks again @johanneskoester!

@mdshw5 mdshw5 merged commit bf48bb4 into mdshw5:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdshw5 mdshw5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanneskoester @mdshw5