Improve default export detection #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
|
@jescalan could you add a test for this? 🙏 So that we make sure there is no regression in the future. |
|
Wow, yes I'm sorry for some reason I wasn't even thinking about it. Of course, I'll add one today |
|
Ok @timneutkens - thanks for keeping me in line there. Eliminated a couple unnecessary regex checks and made the tests much more thorough around this use case. |
|
Thanks! |
johno
pushed a commit
that referenced
this pull request
Feb 18, 2019
* improve default export detection * more extensive testing
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #341
Definitely preferable to get a true parser in here as is being discussed, but this at least resolves the major bug of disallowing the word "default" anywhere within front matter in the meantime! 😁