Ignore non MDX files when processing #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the MDX language server handled TypeScript IntelliSense for JavaScript and TypeScript files as well. This led to duplicate IntelliSense results in the editor if people have also enabled TypeScript IntelliSense. These files are still synchronized with the MDX language server, because they are needed for context, but they no longer yield results when interacted with. This also adds tests for when a document does not exist. Closes #270
remcohaszing
added
🐛 type/bug
🦋 Changeset detectedLatest commit: c352d88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wooorm
approved these changes
Jan 19, 2023
|
This has been released in v1.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the MDX language server handled TypeScript IntelliSense for JavaScript and TypeScript files as well. This led to duplicate IntelliSense results in the editor if people have also enabled TypeScript IntelliSense.
These files are still synchronized with the MDX language server, because they are needed for context, but they no longer yield results when interacted with.
This also adds tests for when a document does not exist.
Closes #270