Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non MDX files when processing #273

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Conversation

remcohaszing
Copy link
Member

Previously the MDX language server handled TypeScript IntelliSense for JavaScript and TypeScript files as well. This led to duplicate IntelliSense results in the editor if people have also enabled TypeScript IntelliSense.

These files are still synchronized with the MDX language server, because they are needed for context, but they no longer yield results when interacted with.

This also adds tests for when a document does not exist.

Closes #270

Previously the MDX language server handled TypeScript IntelliSense for
JavaScript and TypeScript files as well.
This led to duplicate IntelliSense results in the editor if people have
also enabled TypeScript IntelliSense.

These files are still synchronized with the MDX language server,
because they are needed for context, but they no longer yield results
when interacted with.

This also adds tests for when a document does not exist.

Closes #270
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix labels Jan 19, 2023
@remcohaszing remcohaszing requested a review from a team January 19, 2023 11:10
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023

🦋 Changeset detected

Latest commit: c352d88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-mdx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remcohaszing remcohaszing merged commit ed9382e into main Jan 19, 2023
@remcohaszing remcohaszing deleted the ignore-non-mdx-files branch January 19, 2023 13:51
@remcohaszing
Copy link
Member Author

This has been released in v1.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

"Type aliases are only allowed in typescript"
2 participants