Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blank graphql fails validation with misleading error message #439

Closed
richxrich opened this issue Nov 2, 2020 · 2 comments
Closed

Blank graphql fails validation with misleading error message #439

richxrich opened this issue Nov 2, 2020 · 2 comments
Assignees
@piotrze
Labels
Improvement

Comments

@richxrich
Copy link

richxrich commented Nov 2, 2020 •
edited
Loading

Expected behavior

An error message more representative of the issue:
[ time ] Validation failed: Graphql files can't be blank
modules/....

Actual behavior

[time] Validation failed: Query string can't be blank
modules/....

Steps to reproduce the problem

Deploy something with a blank graphql file

Version

  • pos-cli: 4.4.24
  • node: 10.16.3
  • os: Windows 10
@z-x
Copy link
Collaborator

z-x commented Dec 18, 2023 •
edited
Loading

image

Should prevent empty graphql only.

@piotrze piotrze assigned piotrze and unassigned godot Dec 21, 2023
@piotrze
Copy link
Contributor

piotrze commented Dec 21, 2023

Fixed
image

@piotrze piotrze closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotrze piotrze

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@piotrze @richxrich @godot @z-x