Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using "eval" for resource-related calculations #55

Closed
mdziekon opened this issue Jul 14, 2019 · 0 comments · Fixed by #56
Closed

Stop using "eval" for resource-related calculations #55

mdziekon opened this issue Jul 14, 2019 · 0 comments · Fixed by #56
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

Currently, all resource-related calculations (income, energy production & usage) are performed using functions defined as strings, which are then evaluated using eval function. This is just... wrong and terrible, and should be replaced with functions (most likely lambdas).
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Jul 14, 2019
@mdziekon mdziekon changed the title Stop using eval for resource-related calculations Stop using "eval" for resource-related calculations Jul 14, 2019
@mdziekon mdziekon mentioned this issue Jul 15, 2019
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using "eval"s mdziekon/UniEngine
1 participant
@mdziekon