Sending the same video/song with the "Play Now" option incorrectly adds it to Queue

[SoftVision-CiprianMuresan]

[Affected versions]:

• Firefox 52.0 and up
• Min-Vid 0.3.4-dev (built on 3/29/2017)

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Latest Min-Vid add-on with Queue functionality was previously installed on a clean profile.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and navigate to any supported platform.
2. Send a video/song to the mini player.
3. Hover the same video and click the "Play Now" overlay button.
4. Observe the behavior.

[Expected result]:

• The selected video/song starts playback and the one that was playing is moved down one position.

[Actual result]:

• The video/song is added to Queue in the 2nd position and the currently playing video/song is unaffected.

[Notes]:

• Attached a screen recording of the issue:
  

[meandavejustice]

@youwenliang What do you think of this? It seems like it could be interpreted either way..

A: overlay icon should launch a track and add it to the beginning of the queue each time it is pressed (even for duplicates.

B: overlay icon should launch a track and play it, unless the identical track is already playing, then it should start it from the beginning?

[meandavejustice]

Moving this into post-queue-release milestone so that this discussion doesn't hold up the release

[youwenliang]

@meandavejustice

I think B makes more sense and avoids having duplicates in a row.
In this case, does it mean that when I pressed the overlay icon to play a video that is already in the queue, it will move the same video in the queue to the front?

[meandavejustice]

@youwenliang Removing duplicates throughout the whole queue sounds like something we shouldn't do. I know I personally will add certain things to a playlist more than once.

[youwenliang]

@meandavejustice then we should use option A to keep the consistency. Whenever you press "Play Now" it will play immediately and push everything else back in the queue, regardless of the duplicates.

[meandavejustice]

@youwenliang Sounds good.

Closing as this is the current behavior

[SoftVision-CiprianMuresan]

I know a lot of time has passed since the issue was closed, but I somehow missed it.

The current behavior still adds duplicates to the list instead of playing them immediately and pushing the rest back.