Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Submenus for Menuitems like login menu? #58

Closed
netusco opened this issue May 9, 2014 · 3 comments
Closed

Submenus for Menuitems like login menu? #58

netusco opened this issue May 9, 2014 · 3 comments

Comments

@netusco
Copy link
Contributor

netusco commented May 9, 2014

I think that sites with few modules might need to have the option for adding submenus on the main menu.
I did a branch 'submenus' on my fork that is working on my repository.
I didn't do the tests yet, I wanted to know though if people is interested and if there is better approaches than the one I've used.
thanks!

@MichaelJCole
Copy link

Great feature!

@amoshaviv
Copy link
Contributor

Hey @netusco,

Indeed an important feature! Went over you implementation, it looks great, I would also consider recursive submenus with more than two levels(maybe host a menu inside other menus?), you can also submit a PR and we'll add this to the next version.

cheers,
amos

@netusco
Copy link
Contributor Author

netusco commented May 10, 2014

Hey @amoshaviv,

I did some changes in another branch for multi-level dropdown menu support. It works in my repo but it's not responsible as twitter bootstrap stop supporting it. I've added an stylesheet but before trying to make it respond without hover I dropped it.
I think it's probably not the best solution multi-level dropdown... Might be better to add dropdown panel support.
Anyway I'm happy if anyone wants to continue the multi-level dropdown menu where I left it.
https://github.com/netusco/mean/tree/multipleLevelSubmenus
TODO: removeSubmenus (check for levels), tests

I'll have a look at the single submenu branch for PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants