Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make errors more informative in the file-service #210

Open
yonatandt opened this issue Sep 15, 2020 · 0 comments
Open

chore: make errors more informative in the file-service #210

yonatandt opened this issue Sep 15, 2020 · 0 comments
Assignees
@yonatandt
Labels
refactor
Milestone
Unicorns 🦄🦄

Comments

@yonatandt
Copy link
Contributor

The error classes are messy.
A duplicate index error (E11000 in mongo) should be one of the two:

  • FileExistsWithSameName (name-parent-owner)
  • FileExistsInS3 (bucket-key)

Both implements UniqueIndexExistsError which implements ClientError.
Both should
@Shahar-Y Shahar-Y changed the title chore: make errors more informative chore: make errors more informative in the file-service Nov 5, 2020
@Shahar-Y Shahar-Y added this to the Unicorns 🦄🦄 milestone Nov 5, 2020
@yonatandt yonatandt self-assigned this Nov 19, 2020
@yonatandt yonatandt mentioned this issue Nov 19, 2020
Closed
@yonatandt yonatandt linked a pull request Nov 19, 2020 that will close this issue
refactor: make errors more informative #226
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yonatandt yonatandt

Labels
refactor
Projects
None yet
Milestone
Unicorns 🦄🦄
Development

Successfully merging a pull request may close this issue.

refactor: make errors more informative meateam/file-service
2 participants
@yonatandt @Shahar-Y