Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated syntax for Laravel 4 #14

Closed
arvidbjorkstrom opened this issue Jan 30, 2013 · 6 comments
Closed

Updated syntax for Laravel 4 #14

arvidbjorkstrom opened this issue Jan 30, 2013 · 6 comments

Comments

@arvidbjorkstrom
Copy link

I've updated some of the blade syntax for Laravel 4. If you'll add another branch for Laravel 4 I'll be happy to create a pull request to it :)

@cringerjs
Copy link
Contributor

Since the syntax is applied to .blade and .blade.php extensions it wouldn't make sense to start a new branch. The syntax file should remain compatible with both versions of laravel. I submitted a pull request adding the l4 template changes; essentially the use of @extends (instead of @layout) and @EnD (instead of @yield_section and @endsection). If there are more I'd just send a pull request to the dev and or master branch.

@Medalink
Copy link
Owner

Medalink commented Feb 1, 2013

I think a desperate repo that users can install for L4 might be best. Thoughts?

@Medalink
Copy link
Owner

Medalink commented Feb 1, 2013

Separate*

@cringerjs
Copy link
Contributor

The only problem with that is that the user would have to specifically choose which version to install. Since they both apply to the blade/blade.php fileType you wouldn't be able to have both of them installed; at least Sublime wouldn't know which to apply based on the file extension. At the moment Laravel4 is in Beta1 so a lot of people are still developing on both versions. Personally I think it would be best by just adding the Laravel4 syntax to the current repo so it works on both versions.

@arvidbjorkstrom
Copy link
Author

I agree with @cringer as it is under development just adding the new keywords would be the best idea.
The only argument I can find to the opposite is that you might get confused why commands that are highlighted in the syntax aren't working. But that's a minor issue.

Btw. @cringer - take a look at my comment on your pull request #16

@Medalink
Copy link
Owner

These have been merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants