Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player does not respect alwaysShowControls: true during keyboard access of .mejs-time-rail #548

Closed
peterh-capella opened this issue Jul 5, 2012 · 2 comments
Closed

Player does not respect alwaysShowControls: true during keyboard access of .mejs-time-rail #548

peterh-capella opened this issue Jul 5, 2012 · 2 comments

Comments

@peterh-capella
Copy link
Contributor

If the player is instantiated thusly:

$(selector).mediaelementplayer({
    features: ['playpause','progress','current','duration','tracks','volume'],
    alwaysShowControls: true
})

and the controls are accessed by tabbing to the controls, the keyboard commands of forward/reverse arrows move the current time within the mejs-time-rail control. If focus changes (even within the controls), the controls fade out.

I have a test page here:

http://media.capella.edu/NonCourseMedia/HTML5Tests/MEJSIssue/test.html

Steps to reproduce the issue:

  1. Use the tab key to put focus on the play/pause control.
  2. Press spacebar or enter to begin playback of video.
  3. Press the right arrow key.

Player controls should remain visible and focus should remain on play/pause control. Error is that controls fade.
This was referenced Jul 19, 2012
Closed
Merged
johndyer added a commit that referenced this issue Sep 23, 2012
@johndyer
Merge pull request #569 from peterh-capella/Issue548
bfe1076 
attempted fix for Issue #548
@peterh-capella peterh-capella mentioned this issue Jun 27, 2013
Merged
johndyer added a commit that referenced this issue Jul 23, 2013
@johndyer
Merge pull request #923 from peterh-capella/master
e8a9e48 
Multiple fixes: old issue #548, current issues #754 and #902
phuongdh pushed a commit to avalonmediasystem/mediaelement that referenced this issue Oct 18, 2013
@johndyer
Merge pull request mediaelement#569 from peterh-capella/Issue548
d80f70e 
attempted fix for Issue mediaelement#548
phuongdh pushed a commit to avalonmediasystem/mediaelement that referenced this issue Oct 18, 2013
@peterh-capella
fix for controls that hide if keyboard scrubbing
5a4f992 
In version 2.9, I reported issue mediaelement#548, that controls hide when using
keyboard to scrub even if the alwaysShowControls option is set to
"true." Pull request mediaelement#569 merged this fix, but did so in the /build
directory. It appears that fix did not move forward with versions and
the issue is occurring in the latest version. Adding fix in the /src
directory so that future builds get the fix.
phuongdh pushed a commit to avalonmediasystem/mediaelement that referenced this issue Oct 18, 2013
@johndyer
Merge pull request mediaelement#923 from peterh-capella/master
8c8c2e7 
Multiple fixes: old issue mediaelement#548, current issues mediaelement#754 and mediaelement#902
rexblack pushed a commit to rexblack/mediaelement that referenced this issue May 22, 2014
@peterh-capella
attempted fix for Issue mediaelement#548
43f5017 
As detailed in Issue mediaelement#548, if alwaysShowControls is set to true, the
player will still hide the controls if the keyboard is used to
manipulate the player. By adding to this if statement, I prevent the
controls from hiding in that case.
rexblack pushed a commit to rexblack/mediaelement that referenced this issue May 22, 2014
@peterh-capella
attempted fix for Issue mediaelement#548
67e7d3b 
As detailed in Issue mediaelement#548, if alwaysShowControls is set to true, the
player will still hide the controls if the keyboard is used to
manipulate the player. By adding to this if statement, I prevent the
controls from hiding in that case.
rexblack pushed a commit to rexblack/mediaelement that referenced this issue May 22, 2014
@johndyer
Merge pull request mediaelement#569 from peterh-capella/Issue548
1bf226f 
attempted fix for Issue mediaelement#548
rexblack pushed a commit to rexblack/mediaelement that referenced this issue May 22, 2014
@johndyer
Merge pull request mediaelement#569 from peterh-capella/Issue548
68c1726 
attempted fix for Issue mediaelement#548
rexblack pushed a commit to rexblack/mediaelement that referenced this issue May 22, 2014
@peterh-capella
fix for controls that hide if keyboard scrubbing
83f11b1 
In version 2.9, I reported issue mediaelement#548, that controls hide when using
keyboard to scrub even if the alwaysShowControls option is set to
"true." Pull request mediaelement#569 merged this fix, but did so in the /build
directory. It appears that fix did not move forward with versions and
the issue is occurring in the latest version. Adding fix in the /src
directory so that future builds get the fix.
rexblack pushed a commit to rexblack/mediaelement that referenced this issue May 22, 2014
@johndyer
Merge pull request mediaelement#923 from peterh-capella/master
9631ebd 
Multiple fixes: old issue mediaelement#548, current issues mediaelement#754 and mediaelement#902
@gavrochelegnou gavrochelegnou mentioned this issue Jan 7, 2016
Closed
@rafa8626
Copy link
Contributor

@peterh-capella Is this still an issue? If not, can you close this issue, please?

@rafa8626
Copy link
Contributor

rafa8626 commented Aug 9, 2016

@peterh-capella Closing old issues. If you'd like to reopen this, let us know. Thanks!

@rafa8626 rafa8626 closed this as completed Aug 9, 2016
marmite22 pushed a commit to elucidat/mediaelement that referenced this issue Dec 16, 2016
@peterh-capella
attempted fix for Issue mediaelement#548
92cc182 
As detailed in Issue mediaelement#548, if alwaysShowControls is set to true, the
player will still hide the controls if the keyboard is used to
manipulate the player. By adding to this if statement, I prevent the
controls from hiding in that case.
marmite22 pushed a commit to elucidat/mediaelement that referenced this issue Dec 16, 2016
@johndyer
Merge pull request mediaelement#569 from peterh-capella/Issue548
b6b780b 
attempted fix for Issue mediaelement#548
marmite22 pushed a commit to elucidat/mediaelement that referenced this issue Dec 16, 2016
@peterh-capella
fix for controls that hide if keyboard scrubbing
878f9b0 
In version 2.9, I reported issue mediaelement#548, that controls hide when using
keyboard to scrub even if the alwaysShowControls option is set to
"true." Pull request mediaelement#569 merged this fix, but did so in the /build
directory. It appears that fix did not move forward with versions and
the issue is occurring in the latest version. Adding fix in the /src
directory so that future builds get the fix.
marmite22 pushed a commit to elucidat/mediaelement that referenced this issue Dec 16, 2016
@johndyer
Merge pull request mediaelement#923 from peterh-capella/master
2371240 
Multiple fixes: old issue mediaelement#548, current issues mediaelement#754 and mediaelement#902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafa8626 @peterh-capella