attempted fix for Issue #548 #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detailed in Issue #548, if alwaysShowControls is set to true, the player will still hide the controls if the keyboard is used to manipulate the player. By adding to this if statement, I prevent the controls from hiding in that case.
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
attempted fix for Issue mediaelement#548
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
In version 2.9, I reported issue mediaelement#548, that controls hide when using keyboard to scrub even if the alwaysShowControls option is set to "true." Pull request mediaelement#569 merged this fix, but did so in the /build directory. It appears that fix did not move forward with versions and the issue is occurring in the latest version. Adding fix in the /src directory so that future builds get the fix.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
attempted fix for Issue mediaelement#548
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
attempted fix for Issue mediaelement#548
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
In version 2.9, I reported issue mediaelement#548, that controls hide when using keyboard to scrub even if the alwaysShowControls option is set to "true." Pull request mediaelement#569 merged this fix, but did so in the /build directory. It appears that fix did not move forward with versions and the issue is occurring in the latest version. Adding fix in the /src directory so that future builds get the fix.
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
attempted fix for Issue mediaelement#548
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
In version 2.9, I reported issue mediaelement#548, that controls hide when using keyboard to scrub even if the alwaysShowControls option is set to "true." Pull request mediaelement#569 merged this fix, but did so in the /build directory. It appears that fix did not move forward with versions and the issue is occurring in the latest version. Adding fix in the /src directory so that future builds get the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in Issue #548, if alwaysShowControls is set to true, the
player will still hide the controls if the keyboard is used to
manipulate the player. By adding to this if statement, I prevent the
controls from hiding in that case.