Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(focus-source): Added handle.unlock #151

Merged
merged 1 commit into from
Sep 10, 2016

Conversation

jantimon
Copy link
Contributor

@jantimon jantimon commented Sep 9, 2016

Introduces a new method for focus-source: handle.unlock().

For details please see #150

@jantimon jantimon mentioned this pull request Sep 9, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 98.884% when pulling e57ba51 on jantimon:feature/focus-source-unlock into 201a109 on medialize:master.

@@ -97,12 +97,16 @@ The `handle.current()` method does not accept any arguments and returns one of t

### handle.used(`<string>`)

The `handle.used()` method accepts one string argument and returns `true` if it matches the current interaction type.
The `handle.used()` method accepts one string argument and returns `true` if that interaction type has ever been used before.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this is what you meant in #150

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I was referring to line 77. but this fix is correct, too! speaking of line 77, do you mind adding handle.unlock() and its legacy alias handle.lock(false) to the Usage block as well?

It's ok as it is, though. I'll have to add another commit for CHANGELOG.md and the Changes block in this document anyway…

@rodneyrehm rodneyrehm merged commit 83b5332 into medialize:master Sep 10, 2016
@rodneyrehm
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants