State Machine refactor #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armonge
commented
Oct 11, 2018
| { | ||
| tell: "doesNotLikeVoxa" | ||
| }, | ||
| "NoIntent" |
There was a problem hiding this comment.
This was a feature intended since the beginning, finally got it working with code i actually feel good about
We cover all of this code from the VoxaApp specs
armonge
commented
Oct 11, 2018
|
|
||
| afterEach(() => { | ||
| delete process.env.DEBUG; | ||
| process.env = processData; |
There was a problem hiding this comment.
this was deleting my logs in the tests when running them with DEBUG=voxa yarn test --watch --bail
armonge
changed the title
omenocal
approved these changes
Oct 11, 2018
lvelasquezm
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for the State Machine was getting too hairy, i refactored it to get a simpler model, create a new State Class, removed some of the features we rarely use and started using an actual
StateclassBasically we no longer have the
entryspecial state, that also means we now only have 2 ways of specifying a state, a function handler and a literal transition object. Before there was also theentryway, which by the way could also take a function, this was leadomg to harder code in the StateMachine and from looking at our past projects wasn't a feature used often in recent projects