Expose device info to webapp via bridge #95

tookam · 2019-10-22T16:42:30Z

Expose device info to webapp via bridge

Example of info shared by code:

{
  "androidVersion":"7.0",
  "osApiLevel":24,
  "osVersion":"3.18.35(1560398223)",
  "device":"Studio_Mega",
  "model":"Studio Mega",
  "manufacturer":"BLU",
  "harware":"mt6580",
  "freeMemorySize":"1,550MB",
  "totalMemorySize":"4,308MB",
  "freeRAMSize":"231MB",
  "totalRAMSize":"894MB",
  "thresholdRAM":"127MB",
  "cpuInfo":"ARMv7 Processor rev 3 (v7l)"
}

#64

MedicAndroidJavascript.java:264: Error: Field requires API level 23 (current min is 19): android.os.Build.VERSION#SECURITY_PATCH [InlinedApi] String securityPatch = Build.VERSION.SECURITY_PATCH;

SCdF

Great start! Some changes suggested.

Also, did you also look into:

Network capacity re: their sim card (this is may be hard because we might just catch them at a bad time or whatever. It would have to be a static truth that was representative regardless of when we compiled it).

As well?

src/main/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java

tookam · 2019-10-24T19:08:13Z

New json:

{
  "app":{
    "version":"SNAPSHOT"
  },
  "software":{
    "androidVersion":"7.0",
    "osApiLevel":24,
    "osVersion":"3.18.35(1560398223)"
  },
  "hardware":{
    "device":"Studio_Mega",
    "model":"Studio Mega",
    "manufacturer":"BLU",
    "hardware":"mt6580",
    "cpuInfo":{
      "cores":"3",
      "model name":"ARMv7 Processor rev 3 (v7l)"
    }
  },
  "memory":{
    "free":"494MB",
    "total":"4,308MB"
  },
  "ram":{
    "free":"252MB",
    "total":"894MB",
    "threshold":"127MB",
    "maxMemory":"256MB"
  },
  "network":{
    "downSpeed":"1Gbps",
    "upSpeed":"1Gbps"
  }
}

SCdF

This looks awesome dude!

One change: can we have any numerical values that we'd want consider numerical for processing reasons as numbers in JSON, as opposed to strings?

As I see it, that's core count, ram usage and network speed. This allows us to more easily process them later.

tookam · 2019-10-30T18:08:52Z

New json:

{
  "app": {
    "version": "SNAPSHOT"
  },
  "software": {
    "androidVersion": "7.0",
    "osApiLevel": 24,
    "osVersion": "3.18.35(1560398223)"
  },
  "hardware": {
    "device": "Studio_Mega",
    "model": "Studio Mega",
    "manufacturer": "BLU",
    "hardware": "mt6580",
    "cpuInfo": {
      "cores": 3,
      "model name": "ARMv7 Processor rev 3 (v7l)"
    }
  },
  "memory": {
    "free": 1555611648,
    "total": 4517351424
  },
  "ram": {
    "free": 233095168,
    "total": 937918464,
    "threshold": 133169152,
    "maxMemory": 268435456
  },
  "network": {
    "downSpeed": 1048576,
    "upSpeed": 1048576
  }
}

SCdF

Thanks for the updates. Unfortunately I missed a couple of things that I should have caught in the last review... sorry! I know it's annoying to go back and forth a lot and I should have caught them the first time

src/main/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java

SCdF · 2019-10-31T10:51:49Z

src/main/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java

+			long totalRAMSize = memoryInfo.totalMem;
+			long freeRAMSize = memoryInfo.availMem;
+			long thresholdRAM = memoryInfo.threshold;
+			Runtime runtime = Runtime.getRuntime();


Sorry I missed when this was suggested so I didn't comment on it.

This may actually be more of a question for @kennsippell since he suggested it.

Because for us the JVM does basically nothing (because most of the work is XWalk -> Chromium which doesn't run in the JVM), does this value and other values in this class indicate useful things for us? If so why?

If it is useful, I wonder then if we want to pull more from it. Things that look interesting to me: availableProcessors, freeMemory, maxMemory (the one we have), totalMemory.

i agree there likely isn't much value in capturing jvm metrics for our app. they are good to look at to confirm nothing unexpected in the usage - but in terms of capturing regularly and per-user it's probably not that useful...

@wtekeu As stefan suggests, I think this should be safe to remove. Would you mind confirming expectations that the Runtime.getRuntime().totalMemory() number is quite small and thus not capturing much of interest?

SCdF · 2019-10-31T10:52:49Z

src/main/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java

+					.put("free", freeRAMSize)
+					.put("total", totalRAMSize)
+					.put("threshold", thresholdRAM)
+					.put("maxMemory", maxMemorySize);


If we decide to keep this, but only this from the runtime, it should be jvmMaxMemory or runtimeMaxMemory to avoid confusion with the rest of the system information.

If we decide to keep this and expand to the other information we should have a new section for jvm or runtime information.

SCdF

Awesome, nice work!

SCdF · 2019-11-07T09:16:13Z

Now the next step is a cht-core PR to hook this into telemetry, and then we can AT it!

From https://stackoverflow.com/a/30150409

SCdF

Extra notes post merge @wtekeu.

SCdF · 2019-11-25T10:43:57Z

src/main/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java

+			if (data.length > 1) {
+				String key = data[0].trim();
+				if (key.equals("model name")) {
+					output.put(key, data[1].trim());


Now that you're no longer counting cores this way you don't need to keep looping if you find the "model name" key. In fact, you don't need to loop at all, and instead use indexOf

* Expose device info to webapp via bridge medic#64

* Expose device info to webapp via bridge #64

tookam added 4 commits October 22, 2019 12:39

Expose device info to webapp via bridge

85e89f2

Fix style

148498a

Fixes unused import

bc1c193

Fixes lint error

38136af

MedicAndroidJavascript.java:264: Error: Field requires API level 23 (current min is 19): android.os.Build.VERSION#SECURITY_PATCH [InlinedApi] String securityPatch = Build.VERSION.SECURITY_PATCH;

tookam requested a review from SCdF October 22, 2019 18:59

SCdF suggested changes Oct 23, 2019

View reviewed changes

kennsippell reviewed Oct 23, 2019

View reviewed changes

src/main/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java Outdated Show resolved Hide resolved

tookam added 2 commits October 24, 2019 14:42

Restructure returned json and add network info/maximum amount of memory

728a26f

Remove logging

0ecb439

tookam requested review from kennsippell and SCdF October 24, 2019 19:08

SCdF suggested changes Oct 28, 2019

View reviewed changes

tookam added 2 commits October 30, 2019 13:58

Removes formatting

6c5f7a2

Removes formatting of cores

d6e6dc2

tookam requested a review from SCdF October 30, 2019 18:25

SCdF suggested changes Oct 31, 2019

View reviewed changes

Removes jvm info + renames group (memory -> storage)

eb28c64

tookam requested a review from SCdF November 6, 2019 22:48

SCdF approved these changes Nov 7, 2019

View reviewed changes

kennsippell removed their request for review November 14, 2019 23:49

tookam added 2 commits November 22, 2019 15:04

Changes the logic used to compute the cores

82f1cc7

From https://stackoverflow.com/a/30150409

Simplifies logic given that minSdk >= 17

ddf43ae

ngaruko merged commit 68207c0 into master Nov 24, 2019

ngaruko deleted the 64-expose-device-info-to-webapp branch November 24, 2019 22:56

SCdF reviewed Nov 25, 2019

View reviewed changes

nijanthanscs pushed a commit to livinggoods/medic-android that referenced this pull request Dec 30, 2020

Expose device info to webapp via bridge (medic#95)

a063dc7

* Expose device info to webapp via bridge medic#64

nijanthanscs pushed a commit to livinggoods/medic-android that referenced this pull request Dec 30, 2020

Expose device info to webapp via bridge (medic#95)

0871c43

* Expose device info to webapp via bridge medic#64

nijanthanscs pushed a commit to livinggoods/medic-android that referenced this pull request Dec 30, 2020

Expose device info to webapp via bridge (medic#95)

5a5c83a

* Expose device info to webapp via bridge medic#64

derickl pushed a commit that referenced this pull request Jan 21, 2021

Expose device info to webapp via bridge (#95)

8195bb1

* Expose device info to webapp via bridge #64

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose device info to webapp via bridge #95

Expose device info to webapp via bridge #95

tookam commented Oct 22, 2019 •

edited

Loading

SCdF left a comment

tookam commented Oct 24, 2019

SCdF left a comment

tookam commented Oct 30, 2019

SCdF left a comment

SCdF Oct 31, 2019

kennsippell Oct 31, 2019 •

edited

Loading

SCdF Oct 31, 2019

SCdF left a comment

SCdF commented Nov 7, 2019

SCdF left a comment

SCdF Nov 25, 2019

Expose device info to webapp via bridge #95

Expose device info to webapp via bridge #95

Conversation

tookam commented Oct 22, 2019 • edited Loading

SCdF left a comment

Choose a reason for hiding this comment

tookam commented Oct 24, 2019

SCdF left a comment

Choose a reason for hiding this comment

tookam commented Oct 30, 2019

SCdF left a comment

Choose a reason for hiding this comment

SCdF Oct 31, 2019

Choose a reason for hiding this comment

kennsippell Oct 31, 2019 • edited Loading

Choose a reason for hiding this comment

SCdF Oct 31, 2019

Choose a reason for hiding this comment

SCdF left a comment

Choose a reason for hiding this comment

SCdF commented Nov 7, 2019

SCdF left a comment

Choose a reason for hiding this comment

SCdF Nov 25, 2019

Choose a reason for hiding this comment

tookam commented Oct 22, 2019 •

edited

Loading

kennsippell Oct 31, 2019 •

edited

Loading