Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyxform doesn't respect spacing after reference at the beginning of label #3324

Closed
abbyad opened this issue Mar 30, 2017 · 7 comments
Closed

Comments

@abbyad
Copy link
Contributor

abbyad commented Mar 30, 2017

If a label starts with a ${value} the space that follows it is not respected.

A label such as ${input} <-- Test without preceding text, **space is ignored** has the space ignored after ${input}. The spacing is fine if there is text prior to ${input}.

This can be seen with this form, resulting in the following XForm snippet.

    <input ref="/issue-3324/note1">
      <label><output value=" /issue-3324/input "/>&lt;-- Test without preceding text, **space is ignored**</label></input>
    <input ref="/issue-3324/note2">
      <label>.<output value=" /issue-3324/input "/> &lt;-- Test with preceding text, spacing is correct</label>
    </input>

Filing here for now since https://github.com/SEL-Columbia/pyxform/issues hasn't had activity in over two years.

@nice-snek nice-snek added the Status: Blocked waiting for triage Blocked waiting for prioritisation label Jul 4, 2017
@nice-snek
Copy link

hi frand @sglangevin, please triage before the end of this sprint.

@sglangevin
Copy link

Still relevant but not high priority.

@sglangevin sglangevin added 0 - Backlog and removed Status: Blocked waiting for triage Blocked waiting for prioritisation labels Jul 6, 2017
@sglangevin sglangevin removed their assignment Jul 6, 2017
@abbyad
Copy link
Contributor Author

abbyad commented Aug 22, 2017

@alxndrsn is this resolved by your latest work in pyxform?

@alxndrsn alxndrsn self-assigned this Aug 23, 2017
@alxndrsn
Copy link
Contributor

Should be!

@alxndrsn
Copy link
Contributor

Fixed in medic-conf 1.5.0

@alxndrsn alxndrsn added this to the August 21 - September 4 milestone Aug 23, 2017
@sglangevin sglangevin added this to Ready in 2.14.0 Aug 29, 2017
@garethbowen garethbowen reopened this Aug 30, 2017
@alxndrsn alxndrsn changed the title pyxform does respect spacing after reference at the beginning of label pyxform doesn't respect spacing after reference at the beginning of label Aug 30, 2017
@alxndrsn alxndrsn removed their assignment Aug 30, 2017
@sglangevin
Copy link

Assigning to @abbyad for AT.

@abbyad
Copy link
Contributor Author

abbyad commented Aug 31, 2017

Confirmed using the XLSForm from the original post and medic-conf v1.5.6

@abbyad abbyad closed this as completed Aug 31, 2017
@sglangevin sglangevin moved this from In AT to Ready in 2.14.0 Sep 11, 2017
@abbyad abbyad removed their assignment Nov 28, 2017
alxndrsn pushed a commit that referenced this issue Jun 27, 2018
Used the latest pyxform from medic-configurer 1.6.5 to convert the app
forms. They should now all have `<instance id="contact-summary"/>`
(#3413), spaces after output
fields (#3324), and
unescaped quotes. The latter is likely only for legibility reasons only.
alxndrsn pushed a commit that referenced this issue Jun 28, 2018
Used the latest pyxform from medic-configurer 1.6.5 to convert the app
forms. They should now all have `<instance id="contact-summary"/>`
(#3413), spaces after output
fields (#3324), and
unescaped quotes. The latter is likely only for legibility reasons only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2.14.0
  
Ready
Development

No branches or pull requests

5 participants