Handle templated contact/place forms

[alxndrsn]

The forms PLACE_TYPE-create.xlsx, PLACE_TYPE-edit.xlsx need to be converted to:

• clinic-create.xml
• clinic-edit.xml
• district_hospital-create.xml
• district_hospital-edit.xml
• health_center-create.xml
• health_center-edit.xml

The only difference between them is that PLACE_TYPE and PLACE_NAME are replaced differently.

The XForm also has some custom edits to work as a place form and create the contact properly:

• Move place to above person (in data model, due to XML ordering mattering, even though it shouldn't: Order of fields in XML model can break contact creation cht-core#1494)
• Move custom place field from init to within place form - so that it isn't saved in place doc
• Move new contact person to first page - move the group inside previous group
• Add space after output field pyxform doesn't respect spacing after reference at the beginning of label cht-core#3324

The forms at https://github.com/medic/medic-projects/tree/master/standard/forms are fully generated by this convention, so tests could be created based around the xlsx and forms in that project.

[alxndrsn]

Implementation

1. Create forms/contact/PLACE_TYPE-create.xlsx
2. Create forms/contact/PLACE_TYPE-edit.xlsx
3. Create forms/contact/place-types.json:

{
  "clinic": "Clinic",
  "district_hostpital": "District Hostpital",
  "health_center": "Health Center"
}

4. run medic-conf convert-contact-forms as before, and the relevant xforms will be created from the templates.

@abbyad does this look suitable? If you want a way to share template xlsx between projects, this could easily be added. E.g. by changing the JSON file like so:

{
  "templates": "../standard/forms/contact",
  "types": {
    "clinic": "Clinic",
    "district_hostpital": "District Hostpital",
    "health_center": "Health Center"
  }
}

[alxndrsn]

Released in version 1.5.6.

[abbyad]

Overall this works great, and is a nice improvement over having to do this step manually!

Reopening since these don't seem to be done:

• Move custom place field from init to within place form - so that it isn't saved in place doc
  • Rational: we need to show this field in the place group only when relevant, so cannot fully replace the place's name field. Having it there full time would mean having a non-relevant field saved with the place, which is a duplicate field and possibly junk.
  • Currently done crudely here
• Move new contact person to first page - move the group inside previous group
  • Rational: we want to show the new contact fields below the "Select Primary Contact" question, not on a separate page.
  • Currently done crudely here

[alxndrsn]

Filed separately at #21 and #22