Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone field invalid when editing a contact with a valid phone number #7261

Closed
latin-panda opened this issue Aug 18, 2021 · 5 comments
Closed
Assignees
Labels
Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended
Milestone

Comments

@latin-panda
Copy link
Contributor

Describe the bug
Phone field is highlighted as invalid when editing a contact with a valid phone number, because it already exists and can't save unless the phone field gets a new value. It should not highlight the field because the contact is the phone number owner.

To Reproduce
Steps to reproduce the behaviour:

  1. Create a new contact with a unique valid phone number.
  2. Save contact.
  3. Click edit contact and modify another field that is not phone number.
  4. Click save and observe how the phone field is hight lighted as wrong.

Expected behavior
Should not high light the field as wrong if the phone is correct and the contact is the only one assigned to that phone.

Screenshots
Screen Shot 2021-08-18 at 4 32 26 pm

Environment

@latin-panda latin-panda added Type: Bug Fix something that isn't working as intended Priority: 1 - High Blocks the next release. labels Aug 18, 2021
@dianabarsan dianabarsan added this to Ready for dev in Care Teams Workstream via automation Aug 18, 2021
@dianabarsan dianabarsan added this to the 3.13.0 milestone Aug 18, 2021
@dianabarsan dianabarsan self-assigned this Aug 18, 2021
@dianabarsan dianabarsan moved this from Ready for dev to Dev in progress in Care Teams Workstream Aug 18, 2021
@dianabarsan
Copy link
Member

Ready for AT on 7261-edit-contacts-with-phones.

@dianabarsan dianabarsan moved this from Dev in progress to Ready for AT in Care Teams Workstream Aug 19, 2021
@meghna-khemka meghna-khemka moved this from Ready for AT to AT in progress in Care Teams Workstream Aug 19, 2021
@meghna-khemka meghna-khemka self-assigned this Aug 19, 2021
@meghna-khemka
Copy link
Contributor

meghna-khemka commented Aug 23, 2021

Tested above mentioned issue and above issue seems to be working fine but I observed unconsistent behaviour while creating a person with a Phone Number. I do face above mentioned error while creating a new person (Not always but sometime).- Supporting doc attached- (last one -Issue.while.creating.Person.mov)

Both.num.mov
Alternate.Phone.number.mov
Phone.Number.issue.mov
Issue.while.creating.Person.mov

@dianabarsan
Copy link
Member

@meghna-khemka
The phone numbers are both validated, and also checked against other contacts - as two contacts should not have the same phone number. This was what caused the issue in the first place.
In your last video, can you pls make sure you don't have another contact that already uses that phone number?

If you don't, this seems to be another issue. Can you please share the logs from the browser console? Thanks.

@meghna-khemka
Copy link
Contributor

Thanks @dianabarsan
Yeah,It's working fine when we use different phone number's ,may be I was expecting different error message when 2 contact's have same Phone number but looks to be fine if we are displaying same error message.

Happy to pass as mentioned issue is working fine :)

@meghna-khemka meghna-khemka moved this from AT in progress to Ready to merge in Care Teams Workstream Aug 23, 2021
@dianabarsan
Copy link
Member

Thanks @meghna-khemka for the quick AT and feedback!

Merged to master.

Care Teams Workstream automation moved this from Ready to merge to Done Aug 23, 2021
@craig-landry craig-landry removed this from Done in Care Teams Workstream Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

3 participants