Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phone widget failing validation on edit #7266

Merged
merged 6 commits into from Aug 23, 2021
Merged

Fix phone widget failing validation on edit #7266

merged 6 commits into from Aug 23, 2021

Conversation

dianabarsan
Copy link
Member

Description

#7261

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan dianabarsan marked this pull request as ready for review August 18, 2021 19:57
@dianabarsan
Copy link
Member Author

@m5r , please have a look. Thanks!

@dianabarsan dianabarsan requested a review from m5r August 18, 2021 19:58
m5r
m5r requested changes Aug 19, 2021
View reviewed changes
Copy link
Member

@m5r m5r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR overall. I left a few comments and I would like to hear about your thought on that chai.expect() comment before approving

tests/e2e/contacts/new-lineage-structure.wdio-spec.js Show resolved Hide resolved
tests/page-objects/contacts/contacts.wdio.page.js Outdated Show resolved Hide resolved
tests/e2e/contacts/new-lineage-structure.wdio-spec.js Outdated Show resolved Hide resolved
@dianabarsan dianabarsan requested a review from m5r August 19, 2021 08:35
@dianabarsan dianabarsan requested a review from m5r August 19, 2021 11:40
@dianabarsan
Copy link
Member Author

Thanks!

@dianabarsan
Merge branch 'master' into 7261-edit-contacts-with-phones
d2cdd21 
# Conflicts:
#	tests/page-objects/contacts/contacts.wdio.page.js
@dianabarsan
conflict resolutions.
c1bafbb
@dianabarsan dianabarsan merged commit 83fd960 into master Aug 23, 2021
@dianabarsan dianabarsan deleted the 7261-edit-contacts-with-phones branch August 23, 2021 17:22
latin-panda pushed a commit that referenced this pull request Aug 30, 2021
@dianabarsan @latin-panda
Fix phone widget failing validation on edit (#7266)
3be57e2 
Cherry-picked from commit 83fd960
(Removing wdio files since this version is missing dependencies for running this wdio)
latin-panda pushed a commit that referenced this pull request Aug 30, 2021
@dianabarsan @latin-panda
Fix phone widget failing validation on edit (#7266) Cherry-picked fro…
6b8172f 
…m commit 83fd960  (Removing wdio files since this version is missing dependencies for running this wdio)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m5r m5r m5r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dianabarsan @m5r