Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon labels on action buttons are not showing at the default dp for commonly used mobile devices #7721

Closed
michaelkohn opened this issue Aug 10, 2022 · 4 comments · Fixed by #7722
Assignees
Labels
Type: Improvement Make something better UI/UX Site design and usability improvements.
Milestone

Comments

@michaelkohn
Copy link
Member

michaelkohn commented Aug 10, 2022

Labels for icons on action buttons do not render their text if your device's horizontal resolution is 400px or less.

A number of commonly used phones have a horizontal resolution of 720 with a default dp of 360. With this default setting, the icon labels are not showing. If you change the dp to something higher, the labels become visible; however, changing this on every phone is onerous and it also makes the rest of the app text much smaller. At a minimum, we should show the icon labels for the default resolution on these phones.

#6394 addressed the same issue with action labels but intentionally did not address action button icon labels.

Additional context in https://github.com/medic/config-ug-vht/issues/568 (private repo).

screenrez

cc: @n-orlowski

@latin-panda
Copy link
Contributor

latin-panda commented Aug 10, 2022

Hi @ngaruko and @tatilepizs, this is ready for AT in this PR.

It's a small change, basically action button labels should display in smaller font size (just as tabs) when loading in small screens:

Screen Shot 2022-08-10 at 9 50 01 am

@tatilepizs tatilepizs self-assigned this Aug 10, 2022
@tatilepizs
Copy link
Contributor

Config: Default
Environment: Local with docker helper script
cht-core version: 7721-action-buttons-label
Platform: Mobile App. Downloaded from play store version 1.0.1

Android 10

Phone: Samsung Galaxy A01
Android System WebView Version: 103.0.5060.129

Reproducible on "master" image image image image image image
Fixed on "7721-action-buttons-label" image image image image image image

Android 5.1.1

Phone: Alcatel Onetouch 50560
Android System WebView Version: 95.0.4638.74

Reproducible on "master" image image image image image image
Fixed on "7721-action-buttons-label" image image image image image image

latin-panda added a commit that referenced this issue Aug 11, 2022
Tickets: #7721

This commit:
- Enables action's button labels in small font size (same as tab's label)
- Fixes fa-stack icon positioning by making it same height as the other icons in the action bar.
@latin-panda
Copy link
Contributor

@michaelkohn I wanted to add this ticket to the 3.17 milestone but I couldn't find it. I can create it if that's okay. Let me know :)

@mrjones-plip mrjones-plip added this to the 3.17.0 milestone Aug 11, 2022
@mrjones-plip
Copy link
Contributor

I created the milestone \o/

latin-panda added a commit that referenced this issue Aug 31, 2022
Tickets: #7721

This commit:
- Enables action's button labels in small font size (same as tab's label)
- Fixes fa-stack icon positioning by making it same height as the other icons in the action bar.
@latin-panda latin-panda added the UI/UX Site design and usability improvements. label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Make something better UI/UX Site design and usability improvements.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants