New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon labels on action buttons are not showing at the default dp for commonly used mobile devices #7721
Comments
Hi @ngaruko and @tatilepizs, this is ready for AT in this PR. It's a small change, basically action button labels should display in smaller font size (just as tabs) when loading in small screens: |
Config: Default Android 10Phone: Samsung Galaxy A01 Android 5.1.1Phone: Alcatel Onetouch 50560 |
Tickets: #7721 This commit: - Enables action's button labels in small font size (same as tab's label) - Fixes fa-stack icon positioning by making it same height as the other icons in the action bar.
@michaelkohn I wanted to add this ticket to the 3.17 milestone but I couldn't find it. I can create it if that's okay. Let me know :) |
I created the milestone \o/ |
Tickets: #7721 This commit: - Enables action's button labels in small font size (same as tab's label) - Fixes fa-stack icon positioning by making it same height as the other icons in the action bar.
Labels for icons on action buttons do not render their text if your device's horizontal resolution is 400px or less.
A number of commonly used phones have a horizontal resolution of 720 with a default dp of 360. With this default setting, the icon labels are not showing. If you change the dp to something higher, the labels become visible; however, changing this on every phone is onerous and it also makes the rest of the app text much smaller. At a minimum, we should show the icon labels for the default resolution on these phones.
#6394 addressed the same issue with action labels but intentionally did not address action button icon labels.
Additional context in https://github.com/medic/config-ug-vht/issues/568 (private repo).
cc: @n-orlowski
The text was updated successfully, but these errors were encountered: