Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7721 - Display labels in action buttons when device is small #7722

Merged
merged 1 commit into from Aug 11, 2022

Conversation

latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Aug 10, 2022

Description

This PR:

  • Enables action's button labels in small font size (same as tab's label)
  • Fixes fa-stack icon positioning by making it same height as the other icons in the action bar.

#7721

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda
Copy link
Contributor Author

@dianabarsan could you please review this tiny PR? Thanks

@latin-panda latin-panda requested review from njogz and removed request for dianabarsan August 10, 2022 09:04
@latin-panda
Copy link
Contributor Author

Reassigning to @njogz thanks!

Copy link
Contributor

@njogz njogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@latin-panda latin-panda merged commit ac68e6f into master Aug 11, 2022
@latin-panda latin-panda deleted the 7721-action-buttons-label branch August 11, 2022 02:34
latin-panda added a commit that referenced this pull request Aug 31, 2022
Tickets: #7721

This commit:
- Enables action's button labels in small font size (same as tab's label)
- Fixes fa-stack icon positioning by making it same height as the other icons in the action bar.
@craig-landry craig-landry mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon labels on action buttons are not showing at the default dp for commonly used mobile devices
2 participants