Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve nginx config to avoid "listen ... http2 directive is deprecated" warning #8582

Closed
mrjones-plip opened this issue Sep 23, 2023 · 1 comment · Fixed by #8661
Closed
Labels
Type: Technical issue Improve something that users won't notice
Milestone

Comments

@mrjones-plip
Copy link
Contributor

Describe the issue
When starting nginx there's an error:

nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/nginx.conf:37
2023/09/23 00:03:13 [warn] 47#47: the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/nginx.conf:38
nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/nginx.conf:38
2023/09/23 00:03:13 [notice] 47#47: signal process started

Per the note, we should use the non-deprecated config syntax to listen for http2 requests.

This is just a warning (not an error or fatal), but was introduced in #8451

Describe the improvement you'd like
Use correct syntax

Describe alternatives you've considered
ignore it! it won't break when we're least expecting it...right...RIGHT!?!?

@mrjones-plip mrjones-plip added the Type: Technical issue Improve something that users won't notice label Sep 23, 2023
@mrjones-plip
Copy link
Contributor Author

here's the docs and the correct syntax is:

    server {
        listen    443 ssl;
        http2     on;
    }

mrjones-plip added a commit that referenced this issue Oct 24, 2023
mrjones-plip added a commit that referenced this issue Oct 24, 2023
* fix http2 declaration per #8582

* remove http2 from port 80
Benmuiruri pushed a commit that referenced this issue Oct 26, 2023
* fix http2 declaration per #8582

* remove http2 from port 80
@1yuv 1yuv added this to the 4.5.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Technical issue Improve something that users won't notice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants