fix(#8582): fixes http2 declaration warning

[mrjones-plip]

fixes http2 declaration warning

close #8582

Code review checklist

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Tested: Unit and/or e2e where appropriate
• Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

• Core
• CouchDB Single
• CouchDB Cluster

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[mrjones-plip]

How to test:

• check out this branch
• deploy CHT4 with docker helper
• check with curl that CHT defaults to http2, can be forced to http2 and can fall back to http1.1:

  curl  -sI  https://CHT_URL:CHT_PORT/  -o/dev/null -w '%{http_version}\n' 
  curl --http2 -sI  https://CHT_URL:CHT_PORT  -o/dev/null -w '%{http_version}\n' 
  curl --http1.1 -sI  https://CHT_URL:CHT_PORT/  -o/dev/null -w '%{http_version}\n' 
  

• find nginx container name: docker ps --format '{{.Names}}'|grep nginx
• assuming your container is called 4_4_test_nginx_1, copy in updated config: docker exec -it 4_4_test_nginx_1 /usr/sbin/nginx -s reload
• recheck with curl that CHT defaults to http2, can be forced to http2 and can fall back to http1.1:

  curl  -sI  https://CHT_URL:CHT_PORT/  -o/dev/null -w '%{http_version}\n' 
  curl --http2 -sI  https://CHT_URL:CHT_PORT  -o/dev/null -w '%{http_version}\n' 
  curl --http1.1 -sI  https://CHT_URL:CHT_PORT/  -o/dev/null -w '%{http_version}\n' 
  

• restart container and check with docker logs CONTAINER_NAME that the warning isn't there: warn] the "listen ... http2" directive is deprecated

[nydr]

LGTM, love that you're paying attention to these details!

Sidenote: This directive was introduced in 1.25.1 [ref] which the nginx container was upgraded to a few months ago. Since the configuration is packaged with the binary I can't imagine it can cause any issues but noting this just in case

[nydr]

Optional: If you feel up for it feel free to add your test cases to nginx/tests/with_mock.bats, currently it's only looking at http headers

[mrjones-plip]

Optional: If you feel up for it feel free to add your test cases to nginx/tests/with_mock.bats, currently it's only looking at http headers

d'oh - Missed opportunity here! I should have said "Run Makefile tests" as you already had tests in there for http1.1 and http2 checks. That said, I skipped adding more because what we have is sufficient.