Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches messageformat to support incorrect locales #6851

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Patches messageformat to support incorrect locales #6851

merged 3 commits into from
Jan 20, 2021

Conversation

dianabarsan
Copy link
Member

Description

Adds a browserify alias for the messageformat package, to point at its source code instead of the default, minified file.
This makes the existent patch work again.
Adds e2e test to protect against future regressions.

#6848

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

ngaruko
ngaruko approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@ngaruko ngaruko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding e2e tests to monitor for regression :)

@dianabarsan dianabarsan mentioned this pull request Jan 19, 2021
Closed
@dianabarsan dianabarsan merged commit b747f47 into master Jan 20, 2021
@dianabarsan dianabarsan deleted the 6848-dual-monkey-patch-message-format branch January 20, 2021 13:00
dianabarsan added a commit that referenced this pull request Jan 20, 2021
@dianabarsan
Patches messageformat to support incorrect locales (#6851)
dd36f78 
Adds a browserify alias for the messageformat package, to point at its source code instead of the default, minified file.
This makes the existent patch work again.
Adds e2e test to protect against future regressions.

#6848

(cherry picked from commit b747f47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-landry craig-landry craig-landry approved these changes

@ngaruko ngaruko ngaruko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dianabarsan @craig-landry @ngaruko