Language translations not working when not supported by make-plural

[craig-landry]

This was previously addressed with #5705 and regressed in CHT 3.8. The regression comes due to an updated messageformat dependency in CHT 3.8.

The prior fix to messageformat was done via monkey patching, which was applicable for messageformat 2.2.1 and does not work in the current version of messageformat (2.3.0).

[dianabarsan]

Just wanted to point out that the issue manifests a little bit differently now, compared to before.
The reports list loads but when navigating to a contact, where we actually use pluralization, those translations will fail and the console will list errors:

[ngaruko]

Tested using the branch 6848-dual-monkey-patch-message-format, on a local machine, following these steps

1. checkout the master branch

2. do a local deployment as per documentation (basically npm ci, then grunt, then grunt dev-api, then grunt-sentinel, in a nutshell)

3. Go to languages tab in the admin portal > display

4. Add new language (code :ceb, name :Cebuano)

5. Upload a translation file messages-ceb.properties (I copied the tagalog translation from the config-icm repo and added a few translations (make Google Translate your friend) - Upload either manually from the UI/admin portal or with medic-conf --local upload-custom-translations - There is a warning in the terminal: WARN 'cel' is not a recognized ISO 639 language code, please ask admin to set the name

6. Create a user (first a health facility if it is a new db, with no seed data)

7. Log in as the new created user

8. Add a new person and a report that generates tasks

9. Go to tasks and observe all translations look ok (default being English)
   

10. Go to 'Edit User Profile', change the language to Cebuano

11. Go to 'Tasks, observe missing translations (task.days.left`) and error in console....
    

12. Go to contact and observe same...

13. Now, checkout the `` branch

14. Log out and log in again as the user created above & change language to cebuano

15. Go to Task and observe translations work:
    

16. Same with contact page :
    

[ngaruko]

One observation that need further investigation but not related to this PR:
Switching between language seems to be glitchy , one has to move between 2 or more clicks before the choice works. We have seen this before, maybe a regression ?

[dianabarsan]

@ngaruko please tell me if you consider this as ready to be merged.

[ngaruko]

@dianabarsan Yes - This is ready. Please feel free to merge and release a beta (unless @binokaryg would like to include the datepicker in the release?) Then we will do a quick RT around languages/translations before the end of the week.

[binokaryg]

I am still waiting for confirmation from the partner. Will it help if add the draft translations now and change them later before the final release if required?

[dianabarsan]

Merged into master and backported to 3.10.x.