Log error when no compose files were overwritten on upgrade complete #7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
|
Penny for your thoughts, please, @garethbowen . Thanks! |
garethbowen
requested changes
Oct 25, 2022
|
|
||
| if (!upgradeUtils.upgradeResponseSuccess(payload, response)) { | ||
| logger.error('No compose files were updated: %o', response); | ||
| throw new Error('No compose files were updated'); |
There was a problem hiding this comment.
I presume this shows the generic error message in the admin UI? If so, we should improve this error message to have more information about what went wrong and how to fix it.
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
…e-kubernetes Signed-off-by: Diana Barsan <barsan@medic.org>
|
Hey @garethbowen I pushed a change which will also treat responses from |
elvisdorkenoo
pushed a commit
that referenced
this pull request
Nov 9, 2022
elvisdorkenoo
added a commit
that referenced
this pull request
Nov 23, 2022
* add e2e tests to messages tab breadcrumbs * fix breatfeeding typo for delivery form in default config (#7890) #7884 * add GH Action to replace placeholders with staging urls (#7860) * add GH Action for staging urls per #7848 * trying to fix path...how I love how you have to push to test a 1 line change... * Clean up readme and template changes in prep for PR * 2 spaces > 4 spaces per feedback * make search tokens more unique per feedback * test committ to trigger replace action * revert pinning to this branch for testing * collapse decleration of updateme object per feedback * un-collapse decleration of updateme object against feedback * fix typo in branch nane * revert pin to branch * collapse more objects per feedback * unping from branch * Update .github/actions/update-staging-url-placeholders/README.md Co-authored-by: Gareth Bowen <gareth@medic.org> Co-authored-by: Gareth Bowen <gareth@medic.org> * Change staging server db #7879 * apply review recommendations * minor changes * Log error when no compose files were overwritten on upgrade complete (#7863) #7859 * Update deep staging link: builds -> builds_4 * add missing opening quote on couch readme (#7881) Co-authored-by: Gareth Bowen <gareth@medic.org> Co-authored-by: Ashley <8253488+mrjones-plip@users.noreply.github.com> Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7859
Code review checklist
Compose URLs:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.