Fixes convert-bad-dob-format lint errors

Issue: medic/cht-core#1672
medic · Apr 20, 2016 · 1ddae89 · mandric · Apr 20, 2016 · SCdF
1 parent be50823
commit 1ddae89
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/migrations/convert-bad-dob-format.js b/migrations/convert-bad-dob-format.js
@@ -1,10 +1,12 @@
-var async = require('async'),
-    db = require('../db'),
+var db = require('../db'),
     moment = require('moment');
 
+/* jshint ignore:start */
+// (it's more readable to use double quotes)
 var temporaryView = {
-  "map": "function(doc) { if (doc.type === 'person' && doc.date_of_birth && doc.date_of_birth.indexOf(' ') >= 0) { emit(1); }}"
+  'map': "function(doc) { if (doc.type === 'person' && doc.date_of_birth && doc.date_of_birth.indexOf(' ') >= 0) { emit(1); }}"
 };
+/* jshint ignore:end */
 
 module.exports = {
   name: 'convert-bad-dob-format',
@@ -23,12 +25,9 @@ module.exports = {
         return row.doc;
       });
 
-      for(doc of docs) {
-        var currentDob = doc.date_of_birth;
-        var convertedDob = moment(doc.date_of_birth, 'MMM Do, YYYY').format('YYYY-MM-DD');
-
-        doc.date_of_birth = convertedDob;
-      }
+      docs.forEach(function(doc) {
+        doc.date_of_birth = moment(doc.date_of_birth, 'MMM Do, YYYY').format('YYYY-MM-DD');
+      });
 
       db.medic.bulk({
         docs: docs