Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of set property #36

Open
medikoo opened this issue Jul 6, 2015 · 1 comment
Open

Validation of set property #36

medikoo opened this issue Jul 6, 2015 · 1 comment
Assignees
Milestone

Comments

@medikoo
Copy link
Owner

medikoo commented Jul 6, 2015

/cc @kamsi @mtuchowski

Sometimes we try to set properties directly in dbjs via obj.foo = 'bar', but if property of given name was never defined in dbjs (on any object), then it doesn't reach dbjs getter but becomes natural ECMAScript property set.

This behavior leads to issues, as our settings may get lost, when we do not expect it.

It might be good to try to find possibly dev only solution that would warn us about such usage (or even throw). It might be possible in ES6 with usage of proxies, or with Object.observe if V8 implements it.

@medikoo medikoo added this to the v0.1 milestone Jul 6, 2015
@mtuchowski
Copy link
Collaborator

👍

@medikoo medikoo self-assigned this May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants