fix: isNumberValue should not crash on non-coercible values

medikoo · Aug 11, 2017 · 0db765e · 0db765e
1 parent fe5b55a
commit 0db765e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/object/is-number-value.js b/object/is-number-value.js
@@ -3,5 +3,10 @@
 var isValue = require("./is-value");
 
 module.exports = function (value) {
-	return isValue(value) && !isNaN(value);
+	if (!isValue(value)) return false;
+	try {
+		return !isNaN(value);
+	} catch (e) {
+		return false;
+	}
 };
diff --git a/test/.eslintrc.json b/test/.eslintrc.json
@@ -1,4 +1,7 @@
 {
+	"globals": {
+		"Symbol": true
+	},
 	"rules": {
 		"consistent-this": "off",
 		"id-length": "off",

diff --git a/test/object/is-number-value.js b/test/object/is-number-value.js
@@ -12,4 +12,7 @@ module.exports = function (t, a) {
 	a(t(new Number(2)), true, "Number object");
 	a(t("asdfaf"), false, "String");
 	a(t(""), true, "Empty String");
+	if (typeof Symbol === "function") {
+		a(t(Symbol("test")), false, "Symbol");
+	}
 };