Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: should only close top modal on Esc key press #669

Closed
krishnakhandagale opened this issue Jun 9, 2022 · 0 comments · Fixed by #671
Closed

bug: should only close top modal on Esc key press #669

krishnakhandagale opened this issue Jun 9, 2022 · 0 comments · Fixed by #671
Assignees
Labels
bug Something isn't working

Comments

@krishnakhandagale
Copy link

Describe the bug

When there are multiple modal in the page and we click esc key , all of the modals gets closed. It should only close the top modal.

To Reproduce

Add 2 or 3 modals in the same page (nested page), hit esc key

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Provide a clear and concise description of the behaviour expected in the above-mentioned scenario.

Screenshots

If applicable, provide screenshots to explain the bug.

Package versions

  • @medly-components/core :

Additional context

Provide any additional information about the bug or the bug scenario.

@krishnakhandagale krishnakhandagale added the bug Something isn't working label Jun 9, 2022
@abhishekashyap abhishekashyap self-assigned this Jun 14, 2022
@abhishekashyap abhishekashyap changed the title bug: Need a way to know if modal is getting closed by esc key bug: should only close top modal on Esc key press Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants