Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tokens optional #1

Closed
wants to merge 3 commits into from
Closed

Conversation

theRealWardo
Copy link

the spec says auth MAY be implemented so let's ensure that the test client support no auth being implemented on the server.

@murillo128
Copy link
Member

Thank you for the PR! I have added support for optional tokens in c879b1a better.

@murillo128 murillo128 closed this Sep 13, 2021
@theRealWardo
Copy link
Author

thanks @murillo128 ! I do think the signature of publish should still change so that it can more easily and beautifully be called by devs not using token auth. what do you think about that?

- whip.publish(url, token, pc);
+ whip.publish(pc, url, token);

@murillo128
Copy link
Member

murillo128 commented Sep 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants