-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-3815 cache presigned s3 binary urls #3834
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
@dillonstreator is attempting to deploy a commit to the Medplum Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dillonstreator - this looks great
2 requests:
- Let's rename
useCachedS3BinaryUrl
touseCachedBinaryUrl
to try to be backend agnostic. - Let's change the fallback behavior to return the original value
Otherwise lgtm 👍
Thank you!
packages/react-hooks/src/useCachedS3BinaryUrl/useCachedS3BinaryUrl.ts
Outdated
Show resolved
Hide resolved
packages/react-hooks/src/useCachedS3BinaryUrl/useCachedS3BinaryUrl.ts
Outdated
Show resolved
Hide resolved
packages/react-hooks/src/useCachedS3BinaryUrl/useCachedS3BinaryUrl.ts
Outdated
Show resolved
Hide resolved
packages/react-hooks/src/useCachedS3BinaryUrl/useCachedS3BinaryUrl.ts
Outdated
Show resolved
Hide resolved
@codyebberson - I've addressed all the feedback |
Fixes #3794 - MeasureReport.period search (#3850) Extra check for vmcontext bots (#3863) Add and use vite-plugin-turbosnap (#3849) Downgrade chromatic (#3848) Repo sql fixes for cockroachdb (#3844) Remove Health Gorilla from medplum-demo-bots (#3845) fix-3815 cache presigned s3 binary urls (#3834) Use tsvector index for token text search (#3791) rate limit should return `OperationOutcome` (#3843) Add global var "module" to vm context bots (#3842) Fix lookup table tsv indexes (#3841) Always use estimate count first (#3840) Disambiguate getClient (#3839) Fix invalid mermaid graph in diagnostic catalog docs (#3836) fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810) Fix Sonar code smells: mark React props readonly (#3832) RDS proxy (#3827) Fixed lookup tables in migration generator (#3830) Fixed deprecated jest matchers (#3831) Update README.md (#3828) Update fhir-basics.md (#3829) Case study content and images (#3820) Added rdsReaderInstanceType and RDS upgrade docs (#3826) Dependency upgrades (#3825) Separate search popup menus for 'text' and 'token' (#3824) Improve performance of token sort (#3823) Additional logging (#3790) Fix calendar input button style (#3817) Don't add _total default in SearchControl (#3818) Dark mode (#3814) Fixes #3812 - FHIR profile cache bug (#3813) Document using medplum client to integrate with external FHIR servers (#3811) Use specific advisory locks (#3805) Nested transactions (#3788) Fix signin page on graphiql (#3802) fix(heartbeat): start heartbeat on first bind to sub (#3793) Fix async job tests (#3795) Document using vm context bots (#3784) Refactored access policy docs based on customer feedback (#3785) Support Redis TLS config from Env (#3787) feat(subscriptions): add `heartbeat` for WS subs (#3740) Update Bot metrics (#3763)
Fixes #3794 - MeasureReport.period search (#3850) Extra check for vmcontext bots (#3863) Add and use vite-plugin-turbosnap (#3849) Downgrade chromatic (#3848) Repo sql fixes for cockroachdb (#3844) Remove Health Gorilla from medplum-demo-bots (#3845) fix-3815 cache presigned s3 binary urls (#3834) Use tsvector index for token text search (#3791) rate limit should return `OperationOutcome` (#3843) Add global var "module" to vm context bots (#3842) Fix lookup table tsv indexes (#3841) Always use estimate count first (#3840) Disambiguate getClient (#3839) Fix invalid mermaid graph in diagnostic catalog docs (#3836) fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810) Fix Sonar code smells: mark React props readonly (#3832) RDS proxy (#3827) Fixed lookup tables in migration generator (#3830) Fixed deprecated jest matchers (#3831) Update README.md (#3828) Update fhir-basics.md (#3829) Case study content and images (#3820) Added rdsReaderInstanceType and RDS upgrade docs (#3826) Dependency upgrades (#3825) Separate search popup menus for 'text' and 'token' (#3824) Improve performance of token sort (#3823) Additional logging (#3790) Fix calendar input button style (#3817) Don't add _total default in SearchControl (#3818) Dark mode (#3814) Fixes #3812 - FHIR profile cache bug (#3813) Document using medplum client to integrate with external FHIR servers (#3811) Use specific advisory locks (#3805) Nested transactions (#3788) Fix signin page on graphiql (#3802) fix(heartbeat): start heartbeat on first bind to sub (#3793) Fix async job tests (#3795) Document using vm context bots (#3784) Refactored access policy docs based on customer feedback (#3785) Support Redis TLS config from Env (#3787) feat(subscriptions): add `heartbeat` for WS subs (#3740) Update Bot metrics (#3763)
Fixes #3815