Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly search over Period elements #3794

Closed
rahul1 opened this issue Jan 24, 2024 · 3 comments · Fixed by #3864
Closed

Properly search over Period elements #3794

rahul1 opened this issue Jan 24, 2024 · 3 comments · Fixed by #3864
Assignees
@codyebberson
Labels
search Features and fixes related to search
Milestone
January 31st, 2024

Comments

@rahul1
Copy link
Member

rahul1 commented Jan 24, 2024

Background

User Driven: https://medplum.slack.com/archives/C057GEVQCRE/p1706043851251609

The user requested query is "find all measure reports where MeasureReport.period includes today"

Currently, when storing Period elements (e.g. MeasureReport.period), we only index the start of the time range. This means that we can't implement the proper time overlap search semantics defined here

Proposal

  • Index Period.end for search
  • Implement FHIR search semantics for period: return all resources where the Period element overlaps the queried range
@rahul1 rahul1 added the search Features and fixes related to search label Jan 24, 2024
@rahul1
Copy link
Member Author

rahul1 commented Jan 24, 2024

See this GH discussion for more information

@rahul1
Copy link
Member Author

rahul1 commented Jan 25, 2024

Update: User is deploying dependent feature Jan 29th, 2024

codyebberson added a commit that referenced this issue Jan 30, 2024
@codyebberson
Fixes #3794 - MeasureReport.period search
a5a74b7
@codyebberson codyebberson reopened this Jan 31, 2024
medplumbot added a commit that referenced this issue Jan 31, 2024
@medplumbot
Release Version 3.0.2
f8d216d 
Fixes #3794 - MeasureReport.period search (#3850)
Extra check for vmcontext bots (#3863)
Add and use vite-plugin-turbosnap (#3849)
Downgrade chromatic (#3848)
Repo sql fixes for cockroachdb (#3844)
Remove Health Gorilla from medplum-demo-bots (#3845)
fix-3815 cache presigned s3 binary urls (#3834)
Use tsvector index for token text search (#3791)
rate limit should return `OperationOutcome` (#3843)
Add global var "module" to vm context bots (#3842)
Fix lookup table tsv indexes (#3841)
Always use estimate count first (#3840)
Disambiguate getClient (#3839)
Fix invalid mermaid graph in diagnostic catalog docs (#3836)
fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810)
Fix Sonar code smells: mark React props readonly (#3832)
RDS proxy (#3827)
Fixed lookup tables in migration generator (#3830)
Fixed deprecated jest matchers (#3831)
Update README.md (#3828)
Update fhir-basics.md (#3829)
Case study content and images (#3820)
Added rdsReaderInstanceType and RDS upgrade docs (#3826)
Dependency upgrades (#3825)
Separate search popup menus for 'text' and 'token' (#3824)
Improve performance of token sort (#3823)
Additional logging (#3790)
Fix calendar input button style (#3817)
Don't add _total default in SearchControl (#3818)
Dark mode (#3814)
Fixes #3812 - FHIR profile cache bug (#3813)
Document using medplum client to integrate with external FHIR servers (#3811)
Use specific advisory locks (#3805)
Nested transactions (#3788)
Fix signin page on graphiql (#3802)
fix(heartbeat): start heartbeat on first bind to sub (#3793)
Fix async job tests (#3795)
Document using vm context bots (#3784)
Refactored access policy docs based on customer feedback (#3785)
Support Redis TLS config from Env (#3787)
feat(subscriptions): add `heartbeat` for WS subs (#3740)
Update Bot metrics (#3763)
@medplumbot medplumbot mentioned this issue Jan 31, 2024
Merged
@codyebberson
Copy link
Member

This is implemented for MeasureReport.period

Migration plan for full rollout:

  1. Add _range columns for all "date" search parameters
  2. Data migration to populate those new columns
  3. Start using the new columns / stop using the old column
  4. Change the old column to range type
  5. Data migration to populate the original column name
  6. Stop using the temp _range columns
  7. Drop the temp _range columns

github-merge-queue bot pushed a commit that referenced this issue Jan 31, 2024
@medplumbot
Release Version 3.0.2 (#3864)
d0b8f6e 
Fixes #3794 - MeasureReport.period search (#3850)
Extra check for vmcontext bots (#3863)
Add and use vite-plugin-turbosnap (#3849)
Downgrade chromatic (#3848)
Repo sql fixes for cockroachdb (#3844)
Remove Health Gorilla from medplum-demo-bots (#3845)
fix-3815 cache presigned s3 binary urls (#3834)
Use tsvector index for token text search (#3791)
rate limit should return `OperationOutcome` (#3843)
Add global var "module" to vm context bots (#3842)
Fix lookup table tsv indexes (#3841)
Always use estimate count first (#3840)
Disambiguate getClient (#3839)
Fix invalid mermaid graph in diagnostic catalog docs (#3836)
fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810)
Fix Sonar code smells: mark React props readonly (#3832)
RDS proxy (#3827)
Fixed lookup tables in migration generator (#3830)
Fixed deprecated jest matchers (#3831)
Update README.md (#3828)
Update fhir-basics.md (#3829)
Case study content and images (#3820)
Added rdsReaderInstanceType and RDS upgrade docs (#3826)
Dependency upgrades (#3825)
Separate search popup menus for 'text' and 'token' (#3824)
Improve performance of token sort (#3823)
Additional logging (#3790)
Fix calendar input button style (#3817)
Don't add _total default in SearchControl (#3818)
Dark mode (#3814)
Fixes #3812 - FHIR profile cache bug (#3813)
Document using medplum client to integrate with external FHIR servers (#3811)
Use specific advisory locks (#3805)
Nested transactions (#3788)
Fix signin page on graphiql (#3802)
fix(heartbeat): start heartbeat on first bind to sub (#3793)
Fix async job tests (#3795)
Document using vm context bots (#3784)
Refactored access policy docs based on customer feedback (#3785)
Support Redis TLS config from Env (#3787)
feat(subscriptions): add `heartbeat` for WS subs (#3740)
Update Bot metrics (#3763)
@rahul1 rahul1 mentioned this issue Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyebberson codyebberson

Labels
search Features and fixes related to search
Projects
Medplum Product Roadmap
Archived in project
Milestone
January 31st, 2024
Development

Successfully merging a pull request may close this issue.

Release Version 3.0.2 medplum/medplum
2 participants
@codyebberson @rahul1