Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(subscriptions): add heartbeat for WS subs #3740

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat(subscriptions): add heartbeat for WS subs #3740

merged 4 commits into from
Jan 23, 2024

Conversation

ThatOneBro
Copy link
Member

@ThatOneBro ThatOneBro commented Jan 17, 2024 •
edited
Loading

TODO:

  • Add tests for heartbeat functionality

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
medplum-app ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 1:19am
medplum-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 1:19am
medplum-www ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 1:19am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Messages
📖 @medplum/core: 153.9 kB
📖 @medplum/react: 337.0 kB

Generated by 🚫 dangerJS against 5a29ce9

@ThatOneBro ThatOneBro force-pushed the derrick-add-heartbeat-ws-subs branch 2 times, most recently from 325106c to 90b50c5 Compare January 19, 2024 01:42
ThatOneBro
ThatOneBro commented Jan 21, 2024
View reviewed changes
packages/core/src/config.ts
@@ -42,7 +42,7 @@ export interface MedplumSourceInfraConfig {
maxAzs: ValueOrExternalSecret<number>;
rdsInstances: ValueOrExternalSecret<number>;
rdsInstanceType: ValueOrExternalSecret<string>;
rdsInstanceVersion: ValueOrExternalSecret<string>;
rdsInstanceVersion?: ValueOrExternalSecret<string>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this is intended to be optional, this was causing a type error in the tests since it was marked as required, though in the MedplumInfraConfig it is treated as optional

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch

packages/server/src/config.ts Outdated Show resolved Hide resolved
@ThatOneBro ThatOneBro added the subscriptions Features and fixes related to subscriptions label Jan 21, 2024
@ThatOneBro ThatOneBro added this to the January 31st, 2024 milestone Jan 21, 2024
@ThatOneBro ThatOneBro marked this pull request as ready for review January 22, 2024 00:22
@ThatOneBro ThatOneBro requested a review from a team as a code owner January 22, 2024 00:22
codyebberson
codyebberson approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm 👍

Nothing blocking, but a handful of comments for your consideration

packages/core/src/config.ts
@@ -42,7 +42,7 @@ export interface MedplumSourceInfraConfig {
maxAzs: ValueOrExternalSecret<number>;
rdsInstances: ValueOrExternalSecret<number>;
rdsInstanceType: ValueOrExternalSecret<string>;
rdsInstanceVersion: ValueOrExternalSecret<string>;
rdsInstanceVersion?: ValueOrExternalSecret<string>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch

packages/server/src/app.ts Outdated Show resolved Hide resolved
packages/server/src/config.ts Outdated Show resolved Hide resolved
packages/server/src/heartbeat.ts
heartbeat: { type: 'heartbeat' };
};

export const heartbeat = new TypedEventTarget<HeartbeatEventMap>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate conversation, out of scope for this PR, but I wonder if we could combine TypedEventTarget and EventTarget into a single class to avoid the wrapping. Not a big deal, we can discuss offline.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could, shouldn't be an issue

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ThatOneBro ThatOneBro added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit f38c6b8 Jan 23, 2024
20 checks passed
@ThatOneBro ThatOneBro deleted the derrick-add-heartbeat-ws-subs branch January 23, 2024 02:20
@ThatOneBro ThatOneBro mentioned this pull request Jan 24, 2024
Closed
@medplumbot medplumbot mentioned this pull request Jan 31, 2024
Merged
medplumbot added a commit that referenced this pull request Jan 31, 2024
@medplumbot
Release Version 3.0.2
f8d216d 
Fixes #3794 - MeasureReport.period search (#3850)
Extra check for vmcontext bots (#3863)
Add and use vite-plugin-turbosnap (#3849)
Downgrade chromatic (#3848)
Repo sql fixes for cockroachdb (#3844)
Remove Health Gorilla from medplum-demo-bots (#3845)
fix-3815 cache presigned s3 binary urls (#3834)
Use tsvector index for token text search (#3791)
rate limit should return `OperationOutcome` (#3843)
Add global var "module" to vm context bots (#3842)
Fix lookup table tsv indexes (#3841)
Always use estimate count first (#3840)
Disambiguate getClient (#3839)
Fix invalid mermaid graph in diagnostic catalog docs (#3836)
fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810)
Fix Sonar code smells: mark React props readonly (#3832)
RDS proxy (#3827)
Fixed lookup tables in migration generator (#3830)
Fixed deprecated jest matchers (#3831)
Update README.md (#3828)
Update fhir-basics.md (#3829)
Case study content and images (#3820)
Added rdsReaderInstanceType and RDS upgrade docs (#3826)
Dependency upgrades (#3825)
Separate search popup menus for 'text' and 'token' (#3824)
Improve performance of token sort (#3823)
Additional logging (#3790)
Fix calendar input button style (#3817)
Don't add _total default in SearchControl (#3818)
Dark mode (#3814)
Fixes #3812 - FHIR profile cache bug (#3813)
Document using medplum client to integrate with external FHIR servers (#3811)
Use specific advisory locks (#3805)
Nested transactions (#3788)
Fix signin page on graphiql (#3802)
fix(heartbeat): start heartbeat on first bind to sub (#3793)
Fix async job tests (#3795)
Document using vm context bots (#3784)
Refactored access policy docs based on customer feedback (#3785)
Support Redis TLS config from Env (#3787)
feat(subscriptions): add `heartbeat` for WS subs (#3740)
Update Bot metrics (#3763)
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
@medplumbot
Release Version 3.0.2 (#3864)
d0b8f6e 
Fixes #3794 - MeasureReport.period search (#3850)
Extra check for vmcontext bots (#3863)
Add and use vite-plugin-turbosnap (#3849)
Downgrade chromatic (#3848)
Repo sql fixes for cockroachdb (#3844)
Remove Health Gorilla from medplum-demo-bots (#3845)
fix-3815 cache presigned s3 binary urls (#3834)
Use tsvector index for token text search (#3791)
rate limit should return `OperationOutcome` (#3843)
Add global var "module" to vm context bots (#3842)
Fix lookup table tsv indexes (#3841)
Always use estimate count first (#3840)
Disambiguate getClient (#3839)
Fix invalid mermaid graph in diagnostic catalog docs (#3836)
fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810)
Fix Sonar code smells: mark React props readonly (#3832)
RDS proxy (#3827)
Fixed lookup tables in migration generator (#3830)
Fixed deprecated jest matchers (#3831)
Update README.md (#3828)
Update fhir-basics.md (#3829)
Case study content and images (#3820)
Added rdsReaderInstanceType and RDS upgrade docs (#3826)
Dependency upgrades (#3825)
Separate search popup menus for 'text' and 'token' (#3824)
Improve performance of token sort (#3823)
Additional logging (#3790)
Fix calendar input button style (#3817)
Don't add _total default in SearchControl (#3818)
Dark mode (#3814)
Fixes #3812 - FHIR profile cache bug (#3813)
Document using medplum client to integrate with external FHIR servers (#3811)
Use specific advisory locks (#3805)
Nested transactions (#3788)
Fix signin page on graphiql (#3802)
fix(heartbeat): start heartbeat on first bind to sub (#3793)
Fix async job tests (#3795)
Document using vm context bots (#3784)
Refactored access policy docs based on customer feedback (#3785)
Support Redis TLS config from Env (#3787)
feat(subscriptions): add `heartbeat` for WS subs (#3740)
Update Bot metrics (#3763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyebberson codyebberson codyebberson approved these changes

Assignees

@ThatOneBro ThatOneBro

Labels
subscriptions Features and fixes related to subscriptions
Projects
Medplum Product Roadmap
Archived in project
Milestone
January 31st, 2024
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThatOneBro @codyebberson