Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering price lists by customer groups #1286

Closed
zakariaelas opened this issue Mar 31, 2022 · 3 comments · Fixed by #1431
Closed

Support filtering price lists by customer groups #1286

zakariaelas opened this issue Mar 31, 2022 · 3 comments · Fixed by #1431
Assignees

Comments

@zakariaelas
Copy link
Contributor

We want to add support for filtering by customer groups. We should extend the FitlerablePriceListProps here to include a customer_group_id? field of type string[] which would include the list of customer group ids to filter by.

@ologbonowiwi
Copy link

There should be a new class extending FitlerablePriceListProps or customer_group_id? should be putted as a field of FitlerablePriceListProps?

@zakariaelas
Copy link
Contributor Author

Hello @ologbonowiwi! Sorry for the delayed response.

Adding customer_group_id? as a field to the FilterablePriceListProps should be enough ☺️

@pKorsholm pKorsholm self-assigned this Apr 25, 2022
@pKorsholm pKorsholm removed their assignment Apr 25, 2022
@pKorsholm pKorsholm self-assigned this Apr 25, 2022
@pKorsholm pKorsholm linked a pull request Apr 26, 2022 that will close this issue
@olivermrbl
Copy link
Contributor

Resolved in #1431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants