fix(medusa): Complete cart with 100% discount #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
carlos-r-l-rodrigues
pushed a commit
that referenced
this pull request
Aug 22, 2022
…1992) feat(medusa): Convert CollectionService to TypeScript (#1976) feat(medusa): Convert OauthService to TypeScript (#1983) feat(medusa-js): Add Collection batch (remove, add) endpoints (#1958) feat(medusa-react): Add Collection batch (remove, add) endpoints (#1959) feat(medusa-payment-stripe): Add support for Przelewy24 and Blik (#1982) feat(medusa): Convert ShippingProfileService to TypeScript (#1963) feat(medusa): Use transactions in CartCompletionStrategy (#1968) feat(medusa): Convert IdempotencyKeyService to TypeScript (#1995) * feat(medusa): Migrate the idempotency key service to ts + fix * feat(medusa): Finalise idempotency migration * Create late-owls-pump.md * feat(medusa): Polish * feat(medusa): Add case to the error handler * feat(medusa): Add case to the error handler Co-authored-by: olivermrbl <oliver@mrbltech.com> feat(medusa,medusa-telemetry): Add telemetry on feature flags (#2017) chore(medusa): Feature flag loader simplify, deduplicate and increase readability (#2025) feat(medusa:) Convert PaymentProvider + PaymentProviderInterface to TS + (#1773) * feat(payments): Refactor core Payment related * fix(medusa): typings * test(unit): fix suite * test(unit): fix suite * feat(medusa): Improve payment provider container typings * fix(medusa): typings * styles(medusa): renove comments * feat(medusa): cleanup * feat(medusa): Add uniq constraint on payment session and idem key on create-payment-session end point * fix(medusa): migration * fix(medusa): create payment session * feat(medusa): cleanup feat(medusa): Refactor undefined check into a single util (#2024) chore(medusa): Remove intepestive services re instanciation in loop (#2036) * chore(medusa): Renove intepestive services re instanciation in loop * test(medusa): Fix missing deps * fix(medusa): Missing await feat(medusa): Simplify the transaction base service (#2007) **What** Simplify the transaction base service. **How** In fact, it does not need to be template and reduce the extensibility as the type is internally enforce. Now, the type is deduced by this which can be any derived class. fix(medusa): join tracking links to all fulfillments in admin/orders (#2045) Fixes #2042 feat(medusa): Implement the SC migration scripts (#2037) **What** Migrate the existing products to the default sales channel FIXES CORE-434 fix(medusa): Complete cart with 100% discount (#2032) **What** Naive fix to allow carts with 100% discount to be completed. **Why** Discount total is wrongly calculated if `items` and `items.adjustments` is not included in relations upon retrieving the cart. **Thought** This is yet another example of why we need to rethink and refactor totals computation to not depend on what is provided by the user. fix(medusa-payment-stripe): Add item adjustments relation in CartSubcriber (#2052) added upgrade guide for v1.3.6 Revert "added upgrade guide for v1.3.6" This reverts commit 9c3c8cb. feat(medusa): Migrate Return service to ts (#1926) feat(medusa): Add Mongolian currency tugrug (#2067) tests(integration-tests): Allow null updates in discounts (#1299) feat(medusa): Filtering Customer Orders (#975) feat(medusa-js): Add deleteSession endpoint (#1234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Naive fix to allow carts with 100% discount to be completed.
Why
Discount total is wrongly calculated if
itemsanditems.adjustmentsis not included in relations upon retrieving the cart.Thought
This is yet another example of why we need to rethink and refactor totals computation to not depend on what is provided by the user.