feat(utils): autogenerates create and update methods when dto is provided #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2bc06f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
riqwan
force-pushed
the
feat/create-update-factory
branch
from
8429f88
to
1aa5fd1
Compare
adrien2p
reviewed
Mar 20, 2024
packages/utils/src/modules-sdk/abstract-module-service-factory.ts
Outdated
Show resolved
Hide resolved
packages/utils/src/modules-sdk/abstract-module-service-factory.ts
Outdated
Show resolved
Hide resolved
Comment on lines
182
to
202
| } & { | ||
| [ModelName in keyof ModelsConfig as CreateMethodName< | ||
| ModelsConfig, | ||
| ModelName | ||
| >]: { | ||
| ( | ||
| data: ModelsConfig[ModelName]["create_dto"][], | ||
| sharedContext?: Context | ||
| ): Promise<ModelsConfig[ModelName]["dto"][]> | ||
| } | ||
| } & { | ||
| [ModelName in keyof ModelsConfig as UpdateMethodName< | ||
| ModelsConfig, | ||
| ModelName | ||
| >]: { | ||
| ( | ||
| data: ModelsConfig[ModelName]["update_dto"][], | ||
| sharedContext?: Context | ||
| ): Promise<ModelsConfig[ModelName]["dto"][]> | ||
| } | ||
| } |
There was a problem hiding this comment.
todo:we should add the overload as per our convention
There was a problem hiding this comment.
Will you add the single data along side the array data?
There was a problem hiding this comment.
I did already, should be in the new commit
sradevski
reviewed
Mar 20, 2024
Co-authored-by: Adrien de Peretti <adrien.deperetti@gmail.com>
sradevski
approved these changes
Mar 20, 2024
riqwan
changed the title
riqwan
commented
Mar 20, 2024
This was referenced Mar 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
when you provide an optional create_dto or update_dto to the model factory types, the abstract service will generate a simple service method for the public services of the modules.
In the above example, only a create method will be generated, but the update will be skipped.