Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Align the product module HTTP API to follow our conventions #6759

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested review from a team as code owners March 20, 2024 12:33
Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Mar 20, 2024 2:43pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 2:43pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 2:43pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 2:43pm

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 8cc49a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/core-flows Minor
@medusajs/medusa Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@@ -44,3 +51,21 @@ export const remapVariant = (v: ProductVariantDTO) => {
price_set: undefined,
}
}

export const refetchProduct = async (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sradevski sradevski force-pushed the feat/align-product-api-conventions branch from 4aaf12d to 8cc49a5 Compare March 20, 2024 14:40
@sradevski sradevski merged commit 7085939 into develop Mar 20, 2024
18 checks passed
@sradevski sradevski deleted the feat/align-product-api-conventions branch March 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants