Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge money amounts and price set money amounts #6768

Merged
merged 9 commits into from
Mar 21, 2024
Merged

chore: merge money amounts and price set money amounts #6768

merged 9 commits into from
Mar 21, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Mar 21, 2024

what:

  • merges price set money amounts and money amount

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6ba3b78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 3:26pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 21, 2024 3:26pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 3:26pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 3:26pm

@riqwan riqwan changed the base branch from feat/pricing-relationships to develop March 21, 2024 10:13
@riqwan riqwan marked this pull request as ready for review March 21, 2024 10:16
@riqwan riqwan requested a review from a team as a code owner March 21, 2024 10:16
@adrien2p
Copy link
Member

There is a lot of simplification and deletion happening ahah

adrien2p
adrien2p reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

integration-tests/modules/helpers/create-variant-price-set.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-set-money-amount.ts Show resolved Hide resolved
packages/pricing/src/models/price-set-money-amount.ts Show resolved Hide resolved
sradevski
sradevski approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

olivermrbl
olivermrbl approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving these PRs!

packages/pricing/src/models/price-set-money-amount.ts Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit b792c4c into develop Mar 21, 2024
18 checks passed
@kodiakhq kodiakhq bot deleted the feat/merge-money-amount branch March 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski sradevski approved these changes

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@pKorsholm pKorsholm Awaiting requested review from pKorsholm pKorsholm is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riqwan @adrien2p @sradevski @olivermrbl