Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pricing data manipulation #6845

Merged
merged 12 commits into from
Mar 27, 2024
Merged

Fix/pricing data manipulation #6845

merged 12 commits into from
Mar 27, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Mar 27, 2024 •
edited

What

  • Fix returned data order
  • improve implentation
  • rm unnecessary promises and/or promise all
  • replace promise.all for promiseAll

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2024 •
edited

🦋 Changeset detected

Latest commit: 02f0d97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/pricing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Mar 27, 2024 5:39pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:39pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 5:39pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 5:39pm

@adrien2p adrien2p marked this pull request as ready for review March 27, 2024 16:02
@adrien2p adrien2p requested a review from a team as a code owner March 27, 2024 16:02
sradevski
sradevski approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite difficult to follow the changes due to the reordering of the code, but overall it seems fine to me. There is still left to improve probably

packages/pricing/src/services/pricing-module.ts Show resolved Hide resolved
packages/pricing/src/services/pricing-module.ts Show resolved Hide resolved
riqwan
riqwan approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@kodiakhq kodiakhq bot merged commit cf3c9b1 into develop Mar 27, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the fix/pricing-data-manipulation branch March 27, 2024 17:51
This was referenced Mar 27, 2024
Merged
Open
Open
This was referenced Apr 4, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski sradevski approved these changes

@riqwan riqwan riqwan approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@pKorsholm pKorsholm Awaiting requested review from pKorsholm pKorsholm is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adrien2p @sradevski @riqwan @olivermrbl