Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin,admin-ui,medusa): Set default value for host + other minor fixes #7203

Merged
merged 2 commits into from
May 2, 2024

Conversation

kasperkristensen
Copy link
Contributor

What

  • Sets a default value for host for the admin development server - localhost.
  • Bumps the tailwindcss version of @medusajs/admin-ui.
  • Fixes an issue where running medusa develop in a project without @medusajs/admin would print an error about not being able to resolve @medusajs/admin.

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: e3a53d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/admin-ui Patch
@medusajs/medusa Patch
@medusajs/admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 1:15pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 2, 2024 1:15pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 1:15pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 1:15pm

@shahednasser
Copy link
Member

/snapshot-this

Copy link
Contributor

github-actions bot commented May 2, 2024

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin@7.1.14-snapshot-20240502091820
yarn add @medusajs/admin-ui@2.1.15-snapshot-20240502091820
yarn add @medusajs/medusa@1.20.6-snapshot-20240502091820

Latest commit: f430ed7

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue with host being undefined when using the develop command is resolved. LGTM!

@olivermrbl olivermrbl merged commit 1422cd2 into v1.x May 2, 2024
24 checks passed
@olivermrbl olivermrbl deleted the fix/admin-host-bug branch May 2, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants