Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining articles cleanup #2024

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Remaining articles cleanup #2024

merged 6 commits into from
Jul 29, 2024

Conversation

amoedoamorim
Copy link
Contributor

@amoedoamorim amoedoamorim commented Jul 26, 2024

Description

  • Fixes wrong fragment usage
  • Fixes GraphQL warning: description alias used more than once
  • Fixes bad propTypes
  • Fixes needed key prop
  • Fixes unwanted slideout on expand article description
  • Deletes unneeded Relay.Container FooterRelay
  • Refactors SelectAllTh => SelectAllCheckbox

References: CV2-4047, CV2-4944

Type of change

  • Performance improvement and/or refactoring (non-breaking change that keeps existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Security mitigation or enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Automated test (add or update automated tests)

How has this been tested?

Manually

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I've made sure my branch is runnable and given good testing steps in the PR description
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I implemented any new components, they are self-contained, their propTypes are declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers
  • If my components involve user interaction - specifically button, text fields, or other inputs - I have added a BEM-like class name to the element that is interacted with
  • To the best of my knowledge, any new styles are applied according to the design system
  • If I added a new external dependency, I included a rationale for doing so and an estimate of the change in bundle size (e.g., checked in https://bundlephobia.com/)

@amoedoamorim amoedoamorim marked this pull request as ready for review July 26, 2024 22:42
@amoedoamorim amoedoamorim changed the title Cleanup fragments; Refactor SelectAllTh Remaining articles cleanup Jul 26, 2024
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @amoedoamorim , great work on cleaning those up! I added a few comments but they were only "notes" for my own review, no action needed from you. I think you just need to fix unit tests before merging.

src/app/components/article/Articles.js Show resolved Hide resolved
src/app/components/article/Articles.js Show resolved Hide resolved
@amoedoamorim amoedoamorim merged commit d064134 into develop Jul 29, 2024
4 checks passed
@amoedoamorim amoedoamorim deleted the fix/4047-4944-cleanup branch July 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants