Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle limits better #391

Open
meejah opened this issue Aug 30, 2023 · 1 comment
Open

Handle limits better #391

meejah opened this issue Aug 30, 2023 · 1 comment

Comments

@meejah
Copy link
Owner

meejah commented Aug 30, 2023

In #389 (one) core problem turned out to be with Twisted's chosen limits in LineOnlyReceiver: if "too much" is buffered, the connection is closed.

We should provide a better error than this for txtorcon users so that it's more obvious in the future that limits may need to be increased again.

(A longer-term solution would be to determine what Tor's actual limits -- if any -- are here, and use those).

@meejah meejah mentioned this issue Aug 30, 2023
@hellais
Copy link
Contributor

hellais commented Aug 31, 2023

Just dropping a comment that how this looks like from the perspective of a txtorcon user is a traceback in the form of:

Tor unexpectedly disconnected while running: XXXX
Unhandled Error
Traceback (most recent call last):
Failure: builtins.RuntimeError: Tor exited with error-code 0

Hopefully this way future humans have an easier time finding this issue (that's what I was searching for in the issues when I ran into this bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants