-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media stream ID's should be unique #1847
Comments
Already fixed in #1459. |
Thank you, i must have missed that. Closing. |
Notice it hasn't been merged yet, as it's a huge refactoring. It does include that change, though, at least IIRC. |
@lminiero I am sorry for coming back to this old conversation. Am I correct that this issue will never be fixed on legacy branch (0.x) and the only solution is to migrate to multi-stream branch? I also have some 3rd party library that relies on MediaStream.id's uniqueness. #1459 was closed and I lost track of the discussion. |
Currently for the video room plugin at least, remote streams all have the same id "janus". Media Stream ID's are supposed to be unique https://developer.mozilla.org/en-US/docs/Web/API/MediaStream/id
3rd party libraries like iosrtc rely on the media stream id to identify streams, since all remote streams have the same id, it causes bugs like this
So is it possible to update janus to follow the spec and provide unique ids.
Thanks,
Akil
The text was updated successfully, but these errors were encountered: