Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components from /line folder unusable due to TV.js vs Tv.js compilation error #121

Closed
katzelein opened this issue Aug 13, 2019 · 2 comments

Comments

@katzelein
Copy link
Contributor

When trying to compile swarm-icons, there's a casing mismatch between the compiled name of a file Tv.js and the way it is being used in lib/components/line/index.js-- TV.js. If I fix the casing in the compiled index.js, it becomes usable. It looks like there is both a TV.js and Tv.js file in the uncompiled source files, which is probably the source or a side-effect of the issue.

@mmcgahan
Copy link
Contributor

thanks for flagging this - probably better to raise it in Slack in #ask-web-platform in the future because I don't think we have notifications set up for GH Issues in our repos, but it should all be sorted now. You might have to run rm -rf packages/swarm-icons/lib && yarn build from the root of the repo to get back in action for development, but @meetup/swarm-icons version 0.1.1 includes the fix

@katzelein
Copy link
Contributor Author

katzelein commented Aug 14, 2019

That's what I did in the past and was told to submit an issue here instead! Also posted about it on the #swarm channel but received no response (unless that's where you saw this). It might be helpful to fill out the READMEs a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants