Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRT effect looks too dark #57

Closed
megamarc opened this issue Dec 22, 2019 · 3 comments
Closed

CRT effect looks too dark #57

megamarc opened this issue Dec 22, 2019 · 3 comments
Assignees

Comments

@megamarc
Copy link
Owner

Historically my CRT effect keeps brightnes compared to unfiltered image. Release 2.2.0 (February 2019) shows correct behavior.

I've noticed that at least release 2.4.1 shows too dark image when filtered, brightness isn't conserved. I've built it with the 2.2.0 Window.c module (responsible of all window related things, including the CRT effect) but the brightness problem persist. Baffling, must investigate in depth because no other modules are involved.

@megamarc megamarc self-assigned this Dec 22, 2019
@ghost
Copy link

ghost commented Dec 22, 2019

Hola @megamarc
Lo siento, al parecer mi cambio en 2e06cca produce el issue.
2019-12-22_scrot_000

El commit justo anterior no lo hace: 027ea03
2019-12-22_scrot

Es extraño, porque ante cualquier cambio yo lo testeo, pero bueno, sorry.

@megamarc
Copy link
Owner Author

No es tu cambio, es un problema de alineación de una variable que debería ser uint8_t y era bool. Ya lo he solucionado en el commit [9351f91], gracias por mirarlo!

@ghost
Copy link

ghost commented Dec 22, 2019

Me alegra que lo hayas solucionado. Gracias!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant