Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce consistent code formatting in development #176

Open
2 of 3 tasks
ziw-liu opened this issue Sep 16, 2022 · 3 comments
Open
2 of 3 tasks

Enforce consistent code formatting in development #176

ziw-liu opened this issue Sep 16, 2022 · 3 comments
Assignees
Labels
meta About how we organize the project
Milestone

Comments

@ziw-liu
Copy link
Contributor

ziw-liu commented Sep 16, 2022

Problem

Although we depend on the black formatter in the [dev] requirements, it is not currently consistently used, and there are unconventional formatting (wrt PEP 8) widespread in the code base.

Proposed solution

Example

black can be executed from the command line if the user has the [dev] environment activated.
If you are using a modern IDE, formatting can also be done by selecting the black installed in their virtual environment as the formatter backend (VS Code: ^/⌘ ⇧ P and type 'format document with...').

@ziw-liu ziw-liu added the meta About how we organize the project label Sep 16, 2022
@ziw-liu ziw-liu added this to the 1.0.0 milestone Sep 16, 2022
@ziw-liu ziw-liu linked a pull request Sep 16, 2022 that will close this issue
@ziw-liu ziw-liu removed a link to a pull request Sep 16, 2022
This was referenced Sep 16, 2022
@ziw-liu
Copy link
Contributor Author

ziw-liu commented Sep 20, 2022

Another issue to also think about is enforcing consistent Markdown documents with a linter, e.g. this one that is available as both a GitHub Action and an editor plugin.

@talonchandler
Copy link
Collaborator

Can this close @ziw-liu?

@ziw-liu
Copy link
Contributor Author

ziw-liu commented Jul 27, 2023

Let's leave this for 1.0.0. CI checks for style and linting isn't implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta About how we organize the project
Projects
None yet
Development

No branches or pull requests

2 participants