-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
facetsDistribution
counts don't take into account filters
#929
Comments
Hello @lerouxrgd, we are aware of this. In fact there is already an open pr that tries to partially address this issue (#849). There are also two fields in the search response (
I hope this helps you better understand the what's going on under the hood. |
Hi @MarinPostma I’ve a question regarding the facets distributions. It looks like that the count for each criterions is missing except for the one that are currently selected. I’ve tried latest release 0.13, also compiled from master (0.14) and also compiled using PR #849, the result is the same (i'm only talking about facets, not filters ;) |
Hello @hadjedjvincent, I am not completely sure to understand what you mean by "currently selected criterion", but the only thing that facet distribution does is returning an approximation of the number of documents that belong to each variant of the facet categories you used in your facet filter. If a document belongs to 2 categories, then it will be counted twice, one for each category. |
Yes, i perfectly understand this :) However, if I want to look for all dresses that are available in Red or in Blue, it looks like it's not possible at the time. |
@hadjedjvincent thanks for reporting this bug, this is fixed with #944. |
944: Fix facet count r=MarinPostma a=MarinPostma fix bug reported in: #929 (comment) Co-authored-by: mpostma <postma.marin@protonmail.com>
@MarinPostma thank you for your fix. I've made a try, it works fine for the current facet. Following my previous example. If i select Red & Blue facets, i have all my dresses that have Red OR Blue color. |
@hadjedjvincent I observed the same issue as you and it is related to the original issue I think, that is, regular filters are not taken into account for the facetsDistribution counts (whether you apply a facetFilter or not) |
@hadjedjvincent Can you open another issue, this is unrelated to this issue, we'll continue discussing there, thanks! |
@MarinPostma What is the status of this issue? |
The correction of this bug is in progress on your side? |
Hello @jobygoude! Sorry for the delay on this issue. The core team is currently working on a huge refacto of the core engine and does not spend time for the moment on improving features. |
facetsDistribution
counts don't take into account filters
Hello @bb, thanks for making pop this issue in my notifications: I checked with @ManyTheFish, and this issue should have been closed when we merged the new search engine 😂 I completely missed it So, closing this with #1421 🎉 |
Describe the bug
The
facetsDistribution
counts don't take into accountfilters
.To Reproduce
Compare the
facetsDistribution
of a query with and withoutfilters
.Expected behavior
The
facetsDistribution
counts should change based on thefilters
.The text was updated successfully, but these errors were encountered: