-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GitHub search to Meili docs #339
Comments
In order to achieve GitHub search to Meili docs we need 2 things:
The first one can be implemented asap but I would like some feedback from @curquiza & @qdequele on how to modify docs-searchbar. How complicated would that be? |
The search in the library is done here.
(I ping you @Kerollmops because it might be interesting for you) After talking with Thomas, I realized I didn't understand well the behavior of the multi-indexes search! I thought that MeiliSearch would search in many indexes, would get many groups of results, and would do a final sort among these groups. Which is not what the multi-indexes search would be. So, here are the steps to add the GitHub information to the documentation search bar (the order matters!!):
That's not exactly the display that @erlend-sh suggested but that would be the easiest integration to do. Especially because It would not need to change the |
Hum, ok yeah. The multi-indexes search doesn't mixup the results of the different indexes you are searching in, it only returns an array with the different results you would have found if you had requested each indexes independently. The engine can't fix them up because the schema is different and therefore it don't know which fields are better than another. Your new search bar setup seems good, but are you sure you can fit the Github documents into the documentations index? Is the schema equivalent? Will it work? |
Ok so with my suggestion I indeed don't need the multi-indexes search.
That might be complicated but possible. I need to test that and let you know 🙂 I think that could work. The question is more about the apparition priority of the GitHub results in the search bar. I need to find the right settings for that. |
We have discussed this internally and are against adding search issues to the main searchbar. We are afraid it will create too much noise—searching for something and ending up on an ongoing discussion about something that has not been solved might be frustrating and confusing, especially for more inexperienced users. Users come to the docs for unambiguous answers and usage instructions, something which issues only occasionally supply. @dichotommy does believe having a separate search bar might be useful for users who have been unable to find the answer to a problem. |
In similar fashion to this multi-site search, docs.meilisearch.com could include GitHub Issues (and eventually Discussions) as an additional search source:
Originally posted by @erlend-sh in meilisearch/meilisearch#629
The text was updated successfully, but these errors were encountered: