-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Send for RoTxn #191
Comments
According to the documentation it seems that you are right we can't refer to the read transaction from different threads, at least we must synchronize the use (by using a mutex?). According to Howard Chu, we must remove this What's cool is that if we implement
Yanking or Reporting a Security Issue?I have some questions for the crates.io team or Rust developers in general, but should I yank all previous versions of the heed crate? Or should I raise a RustSec advisory about heed that concerns this specific Thank you for the investigation and report again 🙏 |
3952: No more use the broken `sync-read-txn` heed feature r=curquiza a=Kerollmops [We recently found out](meilisearch/heed#191 (comment)) that the `read-sync-txn` heed feature was invalid and must be removed from this crate. We were declaring it in milli/meilisearch but, fortunately, not sharing the `RoTxn`s across threads 😮💨 This PR removes the `sync-read-txn` heed feature form the _Cargo.toml_ file. I will fix this in heed v0.20.0 and will fill a RustSec advisory in the meantime. Co-authored-by: Clément Renault <clement@meilisearch.com>
Reopening as I need to fill a RustSec advisory. |
3952: Use the new safe `read-txn-no-tls` heed feature r=ManyTheFish a=Kerollmops [We recently found out](meilisearch/heed#191 (comment)) that the `read-sync-txn` heed feature was invalid and must be removed from this crate. We were declaring it in milli/meilisearch but, fortunately, not sharing the `RoTxn`s across threads 😮💨 [I recently introduced the `read-txn-no-tls` heed feature](meilisearch/heed#194), which implements `RoTxn: Send` and allows multiple read transactions on a single thread (which we use). This PR removes the `sync-read-txn` heed feature from the _Cargo.toml_ file. I will fix this in heed v0.20.0 and will fill a RustSec advisory in the meantime. Co-authored-by: Clément Renault <clement@meilisearch.com>
I just asked for help in rustsec/advisory-db#1755, and we will continue the discussion there, closing. |
I wanted to make the write transactions
Send
but LMDB's documentation says:However, I think that making
RoTxn: Sync
with thesync-read-txn
is not safe, but I may be mistaken. But, for sure,RoTxn
should implementSend
, since it can be moved to other threads safely.The text was updated successfully, but these errors were encountered: