Rename and document the MDB_NOTLS feature
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
added
bug
Kerollmops
force-pushed
the
rename-document-no-tls-feature-v0-12
branch
from
f6fed1d
to
e8957f2
Compare
Kerollmops
force-pushed
the
rename-document-no-tls-feature-v0-12
branch
from
e8957f2
to
d97575d
Compare
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jul 26, 2023
3952: Use the new safe `read-txn-no-tls` heed feature r=ManyTheFish a=Kerollmops [We recently found out](meilisearch/heed#191 (comment)) that the `read-sync-txn` heed feature was invalid and must be removed from this crate. We were declaring it in milli/meilisearch but, fortunately, not sharing the `RoTxn`s across threads 😮💨 [I recently introduced the `read-txn-no-tls` heed feature](meilisearch/heed#194), which implements `RoTxn: Send` and allows multiple read transactions on a single thread (which we use). This PR removes the `sync-read-txn` heed feature from the _Cargo.toml_ file. I will fix this in heed v0.20.0 and will fill a RustSec advisory in the meantime. Co-authored-by: Clément Renault <clement@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #192 combined with #193 and adapted to the v0.12 branch. Plus, it also bumps the version of heed to v0.12.7. (We were already using the v0.12.6, a tag was present on GitHub 😬).
I know it is technically a breaking change, but I don't want to move to v0.13, and we are the only ones at Meilisearch using this specific branch. It is not published on crates.io.